Support enum input type in launch form #178
Conversation
Signed-off-by: Pianist038801 <[email protected]>
|
Thank you for opening this pull request! 🙌 |
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=========================================
Coverage ? 70.24%
=========================================
Files ? 340
Lines ? 6761
Branches ? 1132
=========================================
Hits ? 4749
Misses ? 2012
Partials ? 0 Continue to review full report at Codecov.
|
| import * as React from 'react'; | ||
| import { DatetimeInput } from './DatetimeInput'; | ||
| import { makeStringChangeHandler, makeSwitchChangeHandler } from './handlers'; | ||
| import { InputProps, InputType } from './types'; | ||
| import { UnsupportedInput } from './UnsupportedInput'; | ||
| import { getLaunchInputId } from './utils'; | ||
|
|
||
| const useStyles = makeStyles(theme => ({ |
There was a problem hiding this comment.
NIT: not a blocker but do we need makeStyles here; couldn't we just send styles as a generic object? (is there a specific reason for useStyle?)
eg,
const formStyle = {
minWidth: 100%;
}
There was a problem hiding this comment.
If we define a style that way, we should use style props of React component.
But I found that we currently use className prop for styling.
That's why I went with such solution, just tried to replicate how it's already implemented.
|
Congrats on merging your first pull request! 🎉 |
# [0.22.0](http://github.com/lyft/flyteconsole/compare/v0.21.0...v0.22.0) (2021-08-04) ### Features * add enum input type in launch form ([#178](http://github.com/lyft/flyteconsole/issues/178)) ([847461f](http://github.com/lyft/flyteconsole/commit/847461f5339921e1a2f68512057a38d8a495a814))
|
🎉 This PR is included in version 0.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Signed-off-by: Pianist038801 [email protected]
TL;DR
Add enum type input in launch form
Type
Are all requirements met?
Complete description
Tracking Issue
flyteorg/flyte#1217
Follow-up issue
NA