fix: handle fullInputs for relaunch workflow #171
Conversation
|
Thank you for opening this pull request! 🙌 |
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=========================================
Coverage ? 70.28%
=========================================
Files ? 340
Lines ? 6747
Branches ? 1127
=========================================
Hits ? 4742
Misses ? 2005
Partials ? 0 Continue to review full report at Codecov.
|
Signed-off-by: Jason Porter <[email protected]>
jsonporter
force-pushed
the
flyteconsole-relaunch-inputs-bugfix
branch
from
152c2d2 to
37ce07a
Compare
There was a problem hiding this comment.
Seems alright to me.
I know we don't have a lot of test coverage around this, but we do cover the case of fetching remote inputs here: https://github.com/flyteorg/flyteconsole/blob/master/src/components/Executions/ExecutionDetails/test/RelaunchExecutionForm.test.tsx
Would be nice if you can add a test case for full inputs there as well!
- added unit tests Signed-off-by: Jason Porter <[email protected]>
|
Congrats on merging your first pull request! 🎉 |
## [0.20.1](http://github.com/lyft/flyteconsole/compare/v0.20.0...v0.20.1) (2021-06-03) ### Bug Fixes * handle fullInputs for relaunch workflow ([#171](http://github.com/lyft/flyteconsole/issues/171)) ([8a4fd82](http://github.com/lyft/flyteconsole/commit/8a4fd82ba16def5460a92fddc9b79a46b02450a9))
|
🎉 This PR is included in version 0.20.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Fixes issue where recent changes made to
flyteadminwere not being supported in UI. The use-case is when a user goes to relaunch a workflow, we now return raw/full inputs when the payload is small enough; this adds support forfullInputssee: flyteorg/flyteadmin@067dc91#diff-9b311b663f43eccf79220bfcae3a565ad26d83532c945f39cfc1f7ba029c22e3