fix: Use name if preferredUsername is empty #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumare3
reviewed
Feb 23, 2021
| @@ -26,7 +26,11 @@ export const UserInformation: React.FC<{}> = () => { | |||
| {profile.value == null ? ( | |||
| <LoginLink /> | |||
| ) : ( | |||
| profile.value.preferredUsername | |||
| profile.value.preferredUsername == null ? ( | |||
There was a problem hiding this comment.
one thing with typescript is need to check undefined at times.
kumare3
approved these changes
Feb 24, 2021
EngHabu
changed the title
flyte-bot
added a commit
that referenced
this pull request
Feb 24, 2021
## [0.19.6](http://github.com/lyft/flyteconsole/compare/v0.19.5...v0.19.6) (2021-02-24) ### Bug Fixes * Use name if preferredUsername is empty ([#148](http://github.com/lyft/flyteconsole/issues/148)) ([0cdd983](http://github.com/lyft/flyteconsole/commit/0cdd9830162f3918d21bf9b6dd874f3484ba88e8))
|
🎉 This PR is included in version 0.19.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Use
namefrom/meresponse ifpreferred_usernameis null.Type
Are all requirements met?
Complete description
Not all OIdP providers fill in all user info fields. Google, we found, uses the
namefield but not thepreferred_usernamefield.Tracking Issue
flyteorg/flyte#657