Migrate from TSLint to ESLint #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobNisco
approved these changes
Dec 8, 2020
package.json
Outdated
| "lint-fix": "tslint --fix --project . && prettier --write './**/*.{js,json}'", | ||
| "lint:hooks": "eslint \"src/**/*.{ts,tsx}\"", | ||
| "lint": "eslint . --ext .js,.jsx,.ts,.tsx", | ||
| "lint-fix": "eslint . --ext .js,.jsx,.ts,.tsx --fix && prettier --write './**/*.{js,json}'", |
There was a problem hiding this comment.
Do we also want prettier to format ts and tsx files?
There was a problem hiding this comment.
Good catch. The separate call to prettier is unnecessary. ESLint is configured to use prettier for formatting rules, so eslint --fix should catch all of it.
I cleaned up the scripts and lint-staged config to skip json/jsx(we don't have jsx files) as well.
schottra
added a commit
that referenced
this pull request
Jan 4, 2021
* ci: move from tslint->eslint * fix: addressing eslint errors * fix: remove passing of unused variable * ci: remove unnecessary prettier config
schottra
added a commit
that referenced
this pull request
Jan 5, 2021
* ci: move from tslint->eslint * fix: addressing eslint errors * fix: remove passing of unused variable * ci: remove unnecessary prettier config
schottra
added a commit
that referenced
this pull request
Jan 6, 2021
* refactor: integrate react-query for execution data fetching (#123) * refactor: using react-query to load top level Execution * refactor: upgrading react-query and fixing execution termination * refactor: handle 401s on queries and do auth flow * refactor: adding conditional refresh for execution status * refactor: cleanup broken files after context refactor * chore: docs * refactor: Remove ExecutionDataCache in favor of react-query (#126) * refactor: first step of using queries for NE table * refactor: removing data cache from first layer of NE table * refactor: removing remaining execution data cache usage * refactor: rename QueryKey type and remove bug workaround * refactor: fixing remaining consumers of NEs * test: adds setup for mock-service-worker (#127) * test: add msw and basic handlers for a few types * test: add mock data for a basic workflow execution * test: fixing/removing tests after adding msw * test: throw on unexpected requests to msw * fix: upgrade TS to fix error and cleanup resulting errors * Migrate from TSLint to ESLint (#128) * ci: move from tslint->eslint * fix: addressing eslint errors * fix: remove passing of unused variable * ci: remove unnecessary prettier config * refactor: clean up mock fixtures and re-enable tests for executions (#130) * test: adding test data for node executions * test: mocks and refactoring to re-enable NodeExecutionDetails tests * chore: lint error * test: getting first test for NE table working again * test: mocks and a couple of tests for NE table * refactor: msw handlers to use a backing map and return 404s * test: more tests for NE table * test: adding fixture for dynamic external workflow * test: using mock fixture for sub workflow tests * test: move remaining mocks to fixtures and fix tests * test: re-enabling more execution tests * fix: removing global query handlers for caching entitiesq * test: re-enable ExecutionNodeViews tests * fix: typo in import path * fix: show DataError by default for failed queries * chore: documentation * chore: pr feedback * test: fixing storybook rendering for NE table * refactor: queries and loading states for (Task)ExecutionDetails * chore: cleanup unused code * fix: adds mock support for launch plans * test: update LoadingSpinner tests * fix: handle error case for NE children * chore: remove todo * fix: typo
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Jan 6, 2021
# [0.18.0](http://github.com/lyft/flyteconsole/compare/v0.17.8...v0.18.0) (2021-01-06) ### Features * improved data fetching for execution details page ([#131](http://github.com/lyft/flyteconsole/issues/131)) ([928f094](http://github.com/lyft/flyteconsole/commit/928f094bee6f84a34325eb1ab88c1ddf88d45541)), closes [#123](http://github.com/lyft/flyteconsole/issues/123) [#126](http://github.com/lyft/flyteconsole/issues/126) [#127](http://github.com/lyft/flyteconsole/issues/127) [#128](http://github.com/lyft/flyteconsole/issues/128) [#130](http://github.com/lyft/flyteconsole/issues/130)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the changes in this feature branch fail linting checks because our updated version of Typescript is not compatible with the version of TSLint we are using.
However, TSLint has been officially deprecated. So instead of updating it, it seems like a better idea to just do the migration to ESLint with the Typescript plugins.
This migration was performed by running
npx tslint-to-eslint-config --prettier, trimming down the ESLint config to extend recommended defaults and use the plugins we need for Typescript, Jest, Prettier, and React/Hooks, and then fixing all errors or disabling the rules generating them.Note: There are still a lot of warnings from ESLint. These can be addressed later.
Full change list
tslintand associated plugins, packages, config files.eslintand added all necessary pluginspackage.jsonscripts to useeslintinstead oftslinteslint --fixto auto-fix any simple errors based on the new settings