Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow role specification for single task executions #119

Merged
merged 5 commits into from
Nov 16, 2020
Merged

fix: allow role specification for single task executions #119

merged 5 commits into from
Nov 16, 2020

Conversation

schottra
Copy link
Contributor

@schottra schottra commented Nov 13, 2020 •
edited
Loading

TL;DR

Adds support for providing a value for authRole when launching a single task execution. This value will be reused if relaunching a single task execution.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

  • Added new input/state to the task from workflow for handling a role type and value. This value is required and will default to IAM for now. I might add a follow-up PR to store the last choice in localStorage to make it easier for those using k8s service accounts.
  • Added unit tests to verify all requirements
  • Updated code for relaunching an execution to support passing through the authRole value from the previous execution.
  • Added a section header for the inputs area to distinguish it from the role input. Added a special case handler for when there are no inputs so that we don't render a header and description with no corresponding controls.

Tracking Issue

flyteorg/flyte#582

Follow-up issue

NA

Screenshots

roleInput

@schottra schottra changed the title Add role to task execution fix: allow role specification for single task executions Nov 13, 2020
@schottra schottra merged commit 1ba0e01 into master Nov 16, 2020
service-github-lyft-semantic-release added a commit that referenced this pull request Nov 16, 2020
@service-github-lyft-semantic-release
chore(release): Release 0.17.6 [skip ci]
8c84d02 
## [0.17.6](http://github.com/lyft/flyteconsole/compare/v0.17.5...v0.17.6) (2020-11-16)

### Bug Fixes

* allow role specification for single task executions ([#119](http://github.com/lyft/flyteconsole/issues/119)) ([1ba0e01](http://github.com/lyft/flyteconsole/commit/1ba0e0184fa71d0d29a1ed0a19e3f851debec583))
@service-github-lyft-semantic-release
Copy link
Contributor

🎉 This PR is included in version 0.17.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@schottra schottra mentioned this pull request Nov 16, 2020
Closed
20 tasks
@schottra schottra deleted the add-role-to-task-execution branch December 4, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@podehnal podehnal podehnal approved these changes

@ttannis ttannis Awaiting requested review from ttannis

@BobNisco BobNisco Awaiting requested review from BobNisco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schottra @service-github-lyft-semantic-release @podehnal