fix: don't skip legacy children check when isParentNode=false #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Oct 22, 2020
## [0.15.1](http://github.com/lyft/flyteconsole/compare/v0.15.0...v0.15.1) (2020-10-22) ### Bug Fixes * don't skip legacy children check when isParentNode=false ([#111](http://github.com/lyft/flyteconsole/issues/111)) ([ed6ede3](http://github.com/lyft/flyteconsole/commit/ed6ede389815cd821ec5fe12e628eea1be80cbac))
|
🎉 This PR is included in version 0.15.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#438
In implementing the original changes to use the
isParentNodeflag, I had assumed that the flag would be completely absent. But due to the way protobuf is deserialized, when the metadata object is present,isParentNodewill default tofalse. This will cause us to incorrectly skip checking for children on legacy node executions by querying the child TaskExecutions first.So, the logic is now to query directly for child node executions if the flag is true, and fall back to the legacy check otherwise.