feat: render CronSchedule #107
Conversation
Render CronSchedule
|
@schottra PTAL. |
| @@ -54,6 +57,18 @@ export const schedulesTableColumns: KeyedColumnProps[] = [ | |||
| label: 'frequency', | |||
| width: schedulesTableColumnsWidths.frequency | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Not exactly sure how this is used.
There was a problem hiding this comment.
This component isn't actually used at the moment. It's left over from the first iteration of the UI which had a very basic view of the schedules (both active and inactive) in a workflow.
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 69.37% 70.31% +0.94%
==========================================
Files 383 383
Lines 6299 6388 +89
Branches 986 1018 +32
==========================================
+ Hits 4370 4492 +122
+ Misses 1929 1896 -33
Continue to review full report at Codecov.
|
| @@ -54,6 +57,18 @@ export const schedulesTableColumns: KeyedColumnProps[] = [ | |||
| label: 'frequency', | |||
| width: schedulesTableColumnsWidths.frequency | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
This component isn't actually used at the moment. It's left over from the first iteration of the UI which had a very basic view of the schedules (both active and inactive) in a workflow.
honnix
force-pushed
the
render-schedule
branch
from
0e87f36 to
2a4c11b
Compare
|
@schottra I fixed the |
|
@honnix Looks good. Thanks for implementing this! |
# [0.15.0](http://github.com/lyft/flyteconsole/compare/v0.14.0...v0.15.0) (2020-10-21) ### Features * render CronSchedule ([#107](http://github.com/lyft/flyteconsole/issues/107)) ([c3c5d5d](http://github.com/lyft/flyteconsole/commit/c3c5d5d347fb1921af3cc7311deecda0b0c72295))
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
| @@ -7,5 +7,6 @@ export const launchPlansTableColumnWidths = { | |||
| export const schedulesTableColumnsWidths = { | |||
| active: 80, | |||
| frequency: 300, | |||
| offset: 300, | |||
There was a problem hiding this comment.
I made a mistake here. :( This is not needed.
This was added mistakenly when working on flyteorg#107 .
This was added mistakenly when working on #107 .
## [0.16.1](http://github.com/lyft/flyteconsole/compare/v0.16.0...v0.16.1) (2020-10-22) ### Bug Fixes * remove not used constant ([#112](http://github.com/lyft/flyteconsole/issues/112)) ([8f6fdf7](http://github.com/lyft/flyteconsole/commit/8f6fdf781bf4087b6298ec3a54bd9fc8407ab910)), closes [#107](http://github.com/lyft/flyteconsole/issues/107)
TL;DR
Render CronSchedule with optional
offsetvalue.Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#529
Follow-up issue
NA