Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orca 679 global atlantis lock #48

Closed
wants to merge 7 commits into from

Conversation

msarvar
Copy link

@msarvar msarvar commented Mar 2, 2021

Added support to create a command specific lock entries to the db/bolt_db, LockCommand, UnlockCommand, and CheckCommandLock.

Implemented a new ApplyLocker interface for locking.go#Client that manages apply lock creation/deletion and lock retrieval.

LocksController has 2 handlers to create and delete apply locks.
Server#Index renders the UI to create/delete the locks.
ApplyCommandRunner expects an object that implements ApplyCommandLocker which boils down to object having IsDisabled function that returns boolean value.
DefaultApplyCommandLocker implements the interface.

In UI it is just a AJAX request that will create/delete the locks for apply. To create a new lock or delete existing one do to atlantis main page.

@msarvar
Copy link
Author

msarvar commented Mar 3, 2021

/ptal @nishkrishnan

@msarvar
Copy link
Author

msarvar commented Mar 3, 2021

/ptal

@nishkrishnan
Copy link
Contributor

I actually think it makes sense to rebase your change on on top of our new release branch to make the review easier to know what we've added and what exists in the branch already.

@mikecutalo mikecutalo deleted the ORCA-679-global-atlantis-lock branch June 8, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants