Support Log Streaming URLs for project without a project name #140
Conversation
… URL when project name is not specified
|
/ptal @nishkrishnan @msarvar @pcalley #orchestration |
There was a problem hiding this comment.
There are several places that need to be updated to make this work.
AsyncProjectCommandOutputHandler uses ProjectCommandContext#PullInfo() to create a unique key for a project. Current implementation of PullInfo() only accounts for RepoName, PullNum, and ProjectName. We need to add additional Workspace to the PullInfo and use RepoRelDir as a ProjectName sub if ProjectName is blank.
From there you can unify the URL into 1: /jobs/{org}/{repo}/{pull}/{project}/{workspace}. Where {project} is either project name or directory.
And you will also need to update JobsController#newProjectInfo to parse workspace parameter from the URL.
server/events/models/models.go
Outdated
| var projectIdentifier string | ||
| if projectName == "" { | ||
| projectIdentifier = strings.ReplaceAll(relDir, "/", "-") | ||
| } else { | ||
| projectIdentifier = projectName | ||
| } |
There was a problem hiding this comment.
let's move this to a helper function GetProjectIdentifier() for ProjectCommandContext and ProjectStatus. This way you don't have to duplicate the logic in two places. Since you are implementing the same function for two different objects, you can create a private function in the models package to be called by both objects
No description provided.