Removing tf show output when streaming logs

[Aayyush]

No description provided.

[Aayyush]

/ptal @nishkrishnan @msarvar

[Aayyush]

/ptal #orchestration

[nishkrishnan]

Would it be better to actually only allow plan and apply specifically instead of just having a deny list?

Upstream has support for using terraform version. and we might want to eventually support terraform import.

[Aayyush]

Yeah I think it makes sense to have an allow list for better control over what's being streamed to the web UI. I've added a LogStreamingValidCmds with init, plan, and apply commands for now. We can add more commands as we go :)

[msarvar]

looks good, there is one change that we need to make. I left a comment

[msarvar]

This needs to always run. outCh is used to display the terraform command output on the PR. isValidCommand is only relevant for c.projectCmdOutputHandler.Send(ctx, message)

[Aayyush]

True! Thanks for the catch :) I've made the change you suggested.

[msarvar]

@Aayyush one more thing :) You need to add the same check for stderr. In case the command fails

atlantis/server/events/terraform/terraform_client.go

Lines 460 to 465 in 12b3873

	s := bufio.NewScanner(stderr)
	for s.Scan() {
	message := s.Text()
	outCh <- Line{Line: message}
	c.projectCmdOutputHandler.Send(ctx, message)
	}