Skip to content

Commit

Permalink
Update server/controllers/websocket/writer.go
Browse files Browse the repository at this point in the history
Co-authored-by: Aayush Gupta <[email protected]>
  • Loading branch information
nishkrishnan and Aayyush authored Nov 16, 2021
1 parent 60e3d59 commit 1df15b6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion server/controllers/websocket/writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func (w *Writer) Write(rw http.ResponseWriter, r *http.Request, input chan strin

conn.SetCloseHandler(func(code int, text string) error {
// Close the channnel after websocket connection closed.
// Will gracefully exit the ProjectCommandOutputHandler.Receive() call and cleanup.
// Will gracefully exit the ProjectCommandOutputHandler.Register() call and cleanup.
// is it good practice to close at the receiver? Probably not, we should figure out a better
// way to handle this case
close(input)
Expand Down

0 comments on commit 1df15b6

Please sign in to comment.