Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description with token now supported #697

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

fauust
Copy link
Contributor

@fauust fauust commented Jul 19, 2022

See: peter-evans/dockerhub-description#10

Bump GH actions versions.

As a reminder, we already discussed this in #325

@mre
Copy link
Member

mre commented Jul 21, 2022

Thanks for keeping an eye on this @fauust.

There's an issue with the pipeline:

Run peter-evans/dockerhub-description@v3
with:
repository: lycheeverse/lychee
readme-filepath: README.md
env:
IMAGE_NAME: lycheeverse/lychee
DOCKER_PLATFORMS: linux/amd64,linux/arm64/v8
DOCKERFILE: Dockerfile-CI.Dockerfile

Because the pipeline is running on your fork and the DOCKER_USERNAME and DOCKER_PASSWORD secrets aren't set.

We can fix this by adding the following condition:

if: github.repository_owner == 'lycheeverse' && github.actor != 'dependabot[bot]' && ( github.event_name != 'pull_request' || github.event.pull_request.head.repo.owner.login == github.event.pull_request.base.repo.owner.login )

@fauust
Copy link
Contributor Author

fauust commented Jul 21, 2022

Yep, thanks. I am not sure if we should skip the whole build step or just those that push to dockerhub.

@mre
Copy link
Member

mre commented Jul 22, 2022

The other steps are just login and setup steps, so I think it's fine if we skip the entire pipeline in this case unless I'm missing something.
In any case, thanks a lot for the addition @fauust. 😃

@mre mre merged commit 3156641 into lycheeverse:master Jul 22, 2022
@fauust
Copy link
Contributor Author

fauust commented Jul 23, 2022

Yes you are right! On other CI I build the image locally and push it in a local registry. But that's not the case here. So skipping is perfectly fine.

@fauust fauust deleted the desc-update-docker branch July 23, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants