Silenced Qt6 compilation warnings #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of them were trivial. Strangely enough, the file `qxtglobalshortcut.cpp` had the MS-Windows newline character, which was corrected by FeatherPad on saving.
|
Looks all fine now, IMO we could release QTerminal Qt6 soon, I don't notice issues in my workflow. |
I neither. Users will tell us more after a release.
I think we should. I'll merge this and lxqt/qtermwidget#549 tomorrow and prepare a release. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of them were trivial.
Strangely enough, the file
qxtglobalshortcut.cpphad the MS-Windows newline character, which was corrected by FeatherPad on saving. That's the cause of what you see on GitHub. Use a GUI diff tool (like kdiff3) to see the real difference.