Reorder XML .ui files to correct tab orders #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected files: ./lxqt-config-session/autostartedit.ui ./lxqt-config-session/autostartpage.ui ./lxqt-config-session/basicsettings.ui ./lxqt-config-session/environmentpage.ui
|
Want to get this into 1.4.0 @tsujan? Tab orders were previously fixed for QTerminal, and PCManFM-Qt; there is also a PR for lxqt-config - if merged it would make 1.3.0 -> 1.4.0 more completely tab-correct. |
|
I assure you that it won't be forgotten, but it should be reviewed by an LXQt dev. Unfortunately, that hasn't happened yet, and I won't have time before the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reordered XML .ui files to correct tab orders throughout lxqt-session.
Affected files:
./lxqt-config-session/autostartedit.ui
./lxqt-config-session/autostartpage.ui
./lxqt-config-session/basicsettings.ui
./lxqt-config-session/environmentpage.ui