Cleanup and consistency changes #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you are interested in these changes, I am using your plugin with Mura 6.2 and found that the protocol and http_host are not needed when you call the getImageURL() Mura method. It returns the entire URL for you already. I don't know if this is different behavior from previous versions of Mura or not.
While I was modifying this file I also noticed some inconsistencies on when new lines #NL# were being added to the end of the <meta> tags. They were not being added in all cases.
I also noticed that it was calling the getValue() method in some cases but specific get{attribute_name} in others. I changed the getValue() calls to use the get{attribute_name} methods instead.
I changed the $.content() method calls for the summary and body content to use the $.setDynamicContent() method instead. That way any [Mura] tags embedded in the content will be processed. Don't know if you intentionally were not using this method for some reason?
Just FYI if you want these changes or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are interested in these changes, I am using your plugin with Mura 6.2 and found that the
protocolandhttp_hostare not needed when you call thegetImageURL()Mura method. It returns the entire URL for you already. I don't know if this is different behavior from previous versions of Mura or not.While I was modifying this file I also noticed some inconsistencies on when new lines
#NL#were being added to the end of the<meta>tags. They were not being added in all cases.I also noticed that it was calling the
getValue()method in some cases but specificget{attribute_name}in others. I changed thegetValue()calls to use theget{attribute_name}methods instead.I changed the
$.content()method calls for thesummaryandbodycontent to use the$.setDynamicContent()method instead. That way any[Mura]tags embedded within the content will be processed. I don't know if you intentionally were not using this method for some reason?Just FYI if you want these changes or not.