Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IINA.app windows sometimes not showing #1037

Closed
alt-tab-macos-bot opened this issue Jul 15, 2021 · 9 comments
Closed

IINA.app windows sometimes not showing #1037

alt-tab-macos-bot opened this issue Jul 15, 2021 · 9 comments
Labels
bug Something isn't working unreproducible Need help from the author to reproduce the issue

Comments

@alt-tab-macos-bot
Copy link

This issue was opened by a bot after a user submitted feedback through the in-app form.

Message:

The video player app IINA cannot be displayed.

I cannot reproduce it every time. But in most cases, when I "quickly" open a video from the welcome screen of IINA instead of double clicking the video file, the problem will occur.

Debug profile

  • App version: 6.22.1
  • App preferences:
    • MSAppCenter310AppCenterUserDefaultsMigratedKey: 1
    • MSAppCenter310CrashesUserDefaultsMigratedKey: 1
    • MSAppCenterAppDidReceiveMemoryWarning: 1
    • MSAppCenterInstallId: 4CFD0D3F-9FC0-41E6-AB8C-21970D41ADF2
    • MSAppCenterPastDevices: {length = 1134, bytes = 0x62706c69 73743030 d4010203 04050607 ... 00000000 0000037c }
    • MSAppCenterSessionIdHistory: {length = 452, bytes = 0x62706c69 73743030 d4010203 04050607 ... 00000000 0000014e }
    • MSAppCenterUserIdHistory: {length = 447, bytes = 0x62706c69 73743030 d4010203 04050607 ... 00000000 00000149 }
    • NSStatusItem Visible Item-0: 0
    • SUHasLaunchedBefore: 1
    • SULastCheckTime: 2021-07-11 21:39:34 +0000
    • appsToShow: 0
    • crashPolicy: 0
    • dontShowBlacklist:
    • fadeOutAnimation: true
    • hideColoredCircles: true
    • hideThumbnails: false
    • hideWindowlessApps: true
    • iconSize: 26
    • maxHeightOnScreen: 66
    • menubarIcon: 3
    • mouseHoverEnabled: false
    • preferencesVersion: 6.22.1
    • rowsCount: 4
    • shortcutStyle: 1
    • showHiddenWindows: 0
    • showMinimizedWindows: 1
    • updatePolicy: 1
    • windowMaxWidthInRow: 30
  • Applications: 41
  • Windows: 3
    • {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceId: 4, spaceIndex: 1}
    • {isFullscreen: false, isWindowlessApp: false, isMinimized: false, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: true, spaceId: 4, spaceIndex: 1}
    • {isFullscreen: false, isWindowlessApp: false, isMinimized: true, isHidden: false, isTabbed: false, isOnAllSpaces: false, shouldShowTheUser: false, spaceId: 4, spaceIndex: 1}
  • OS version: Version 10.15.7 (Build 19H1217)
  • OS architecture: x86_64
  • Locale: en_US (current)
  • Spaces: 1
  • Dark mode: Light
  • "Displays have separate Spaces": checked
  • Hardware model: MacBookPro12,1
  • Screens: 1
    • {x: 0.0, y: 0.0, width: 1440.0, height: 900.0}
  • CPU model: Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
  • Memory size: 8.59 GB
  • Active CPU count: 4
  • Current CPU frequency: 2.7 Ghz
  • Resource utilization:
    • CPU: 0.4%
    • Memory: 75M
    • Threads count: 17

@lwouis lwouis changed the title [In-app feedback] IINA.app sometimes doesn't show window in AltTab Aug 12, 2021
@lwouis lwouis changed the title IINA.app sometimes doesn't show window in AltTab IINA.app windows sometimes not showing Aug 12, 2021
@lwouis lwouis added accessibility Accessibility specific issue bug Something isn't working and removed accessibility Accessibility specific issue labels Aug 12, 2021
@lwouis
Copy link
Owner

lwouis commented Aug 12, 2021

I couldn't reproduce the issue. I'm suspecting that the OP is opening the video directly in fullscreen, and that the issue they encounter is #1002.

No contact info, so closing this

@lwouis lwouis closed this as completed Aug 12, 2021
@lwouis lwouis added duplicate This issue or pull request already exists unactionable Further action is not possible due to lack of information or support unreproducible Need help from the author to reproduce the issue labels Aug 12, 2021
@theSiJin
Copy link

Thanks for the response. I reported the issue and I'd like to share more details.

Firstly, this is not a duplicate because the application is not opened in fullscreen.

I can (almost) reproduce the issue as follows:

  1. In settings of IINA, select "show welcome window" in General -> Behavior -> At launch. (Not necessary, but makes the process easier)
  2. Quit the IINA app completely.
  3. Open the IINA app. So far Alt-tab can detect the IINA welcome window correctly.
  4. Open a video. Now sometimes Alt-tab can detect IINA and sometimes not.
  5. If IINA is correctly detected, close (and don't quit) the IINA, and repeat step 3 & 4.

Not sure if it is related, but one observation is that when IINA open a video, it seems that the application will close the welcome window and open the video in a new one.

I took a video on the reproduction. Alt-tab can detect IINA for the first time of launch, but failed in the second time.

Screen.Recording.2021-08-21.at.9.02.16.PM.mp4

@lwouis
Copy link
Owner

lwouis commented Aug 23, 2021

I tried like 10 times, and it always shows for me. I notice that for me opening a video is way faster than on your video. The player opens faster and resizes to the video size in a faster animation. See how it looks like on my system:

iina.mov

I note that we both use IINA 1.1.2. Which macOS version are you on?

@lwouis lwouis reopened this Aug 23, 2021
@lwouis lwouis removed duplicate This issue or pull request already exists unactionable Further action is not possible due to lack of information or support labels Aug 23, 2021
@theSiJin
Copy link

theSiJin commented Aug 25, 2021

The system is 10.15.7 on an early 2015 13-inch MBP (sadly it is slow). It is probably the reason that I personally cannot always reproduce the bug on my machine because it is fast sometimes and slow otherwise. I have searched around and haven't found anyone else having the same problem, so I don't think it is a common bug with IINA or alt-tab either.

Edited: The debug profile in the thread is from my machine. Feel free to use it as reference.

@lwouis
Copy link
Owner

lwouis commented Aug 29, 2021

The only thing I could imagine is that something like #481 (comment) is at play: that the IINA window is first spawned in a state that AltTab discriminates as "not an actual window". Then later it's updated to be an actual window. Depending on how long it stays in this invalid state before being an actual window, and depending on the timing of AltTab accessibility call finishing, it could explain why it sometimes doesn't show.

What we could do is simply whitelist all windows from IINA, like we did for Books.app. @theSiJin if all windows from IINA are indeed windows (not pop-ups, or HUDs, etc), then I could add it to the whitelist and ship a new release that would stop checking if IINA's windows are actual windows and just show anything window-like. It may fix the issue for you. What do you think?

@theSiJin
Copy link

It sounds good. But frankly speaking I'm not a developer, and I'm not 100% certain that all windows from IINA are indeed windows. Appreciate for your help. I can provide you more feedback after the fix.

@p8128n
Copy link

p8128n commented Sep 9, 2021

I have noticed IINA does not show up if Alttab is already running and I open a new IINA window with the 'float on top' option set on. If I turn off 'float on top' and relaunch Alttab it then shows up.

@lwouis
Copy link
Owner

lwouis commented Sep 10, 2021

Indeed, I tested with this preference:

image

And AltTab notices the window is level == 2 (floating). AltTab doesn't show floating windows on purpose. See the comment in the source code: "filter out iStats Pro and other top-level pop-overs, and floating windows".

@theSiJin did you perhaps change some preferences of IINA? I tried to reproduce the issue in this ticket with the default preferences, but if you changed some on your side, it may be why I can't reproduce. This setting on the screenshot above for instance directly prevents windows to show in AltTab. Maybe there are others.

Regardless, I will whitelist IINA in the next AltTab release. This will make it so any window/popup/etc from IINA will show in AltTab.

@lwouis lwouis closed this as completed in 47d283e Sep 18, 2021
lwouis pushed a commit that referenced this issue Sep 18, 2021
# [6.25.0](v6.24.0...v6.25.0) (2021-09-18)

### Bug Fixes

* "show on active screen" could show the wrong screen (closes [#1129](#1129)) ([23bbd64](23bbd64))
* windows from the iina app would not show sometimes (closes [#1037](#1037)) ([47d283e](47d283e))

### Features

* improve localization in hindi, arabic, vietnamese ([2905f7d](2905f7d))
* improve voiceover and speech accessibility ([194e726](194e726))
@theSiJin
Copy link

Yes, I checked the Always float on top while playing box all the time. The new version solved the issue. Great thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unreproducible Need help from the author to reproduce the issue
Projects
None yet
Development

No branches or pull requests

4 participants