aarch64/4.4.y: implicit declaration of function ‘csum_ipv6_magic’ #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately the first commit breaks the build with 3.10.y/3.14.y, so I've added a hack (second commit) to add the extra header only with 4.0.0+. I know this is not the right solution but I'm not a C coder and it's good enough for my needs. Hopefully you might know a better solution (happy to help test/update this PR if you think of anything). This is the build error with 3.14.29 without the second commit: |
|
OK the above is complete crap as my testing was incomplete - now trying to come up with a solution that allows this driver to build for 3.10.y (arm), 3.14.y (arm), 4.4.y (aarch64) and 4.17.y (arm, x86_64). Sigh (the error in my second comment isn't due to the first commit as I thought). |
|
I've dropped the second commit as not required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with aarch64 (kernel 4.4.y), the following error occurs:
This PR fixes this issue.