Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returned original module name. #34

Open
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

hanipouspilot
Copy link

Some dkms.conf cleanup

This one is always selected.

Signed-off-by: Larry Finger <[email protected]>
This variable is always selected.

Signed-off-by: Larry Finger <[email protected]>
The standard kernel features can be used to implement bridges.

Signed-off-by: Larry Finger <[email protected]>
Since converting to CFG80211, warnings of the following type have been issued:

[88526.660804] WARNING: CPU: 3 PID: 9705 at net/wireless/sme.c:848 __cfg80211_disconnected+0x3b8/0x3e0 [cfg80211]()

Signed-off-by: Larry Finger <[email protected]>
All of this functionality can be handled by cfg80211.

Signed-off-by: Larry Finger <[email protected]>
Signed-off-by: Larry Finger <[email protected]>
Signed-off-by: Larry Finger <[email protected]>
Thhis hack is replaced by traditional operations on the skb.

Signed-off-by: Larry Finger <[email protected]>
The original driver is capable of about 80 Mbps when running netperf
TCP tests. Commit d88f1fa introduced an error that cut the throughput
to about 30 Mbps. These changes improve the results to RX of 46 and TX
of 60 Mbps.

Signed-off-by: Larry Finger <[email protected]>
lwfinger and others added 16 commits November 14, 2014 14:05
This patch fixes the remaining bug that was limiting the 5G rate.
Both RX and TX get in excess of 80 Mbps using netperf. In fact, the
actual rate could be higher as my netperf server is connected to the AP
with a 100 Mbps wired connection, and netperf only gets about 90 Mbps
over the wire.

Signed-off-by: Larry Finger <[email protected]>
For some reason, an extra parameter was added to the call to cfg80211_rx_mgmt()
in kernel 3.17, and then removed in 3.18.

Signed-off-by: Larry Finger <[email protected]>
There are two warnings left.

Signed-off-by: Larry Finger <[email protected]>
A warning that appears with kernel 4.1 is also fixed.

Signed-off-by: Larry Finger <[email protected]>
Some dkms.conf cleanup
@lwfinger
Copy link
Owner

This change is OK, but I will not merge it as it violates my naming convention. Names rtlxxxxyy are reserved for drivers in the regular wireless tree. Names rxxxxyy are for drivers in the staging tree, and names xxxyy are for drivers that are not merged into any kernel tree.

Why did you need to change the name?

@hanipouspilot
Copy link
Author

When installing with dkms it is not good to change original names or blacklist original modules.
DKMS stores them in a different place and replaces the original modules with new ones on install. And reverse it on uninstall.
If we keep different names there may be conflict between two modules. But in this case there is no rtl8192du in kernel, if I am correct.

@lwfinger
Copy link
Owner

Correct, there is no rtl8192du in the kernel, and there is never likely to be. That would require a complete rewrite of the driver to use mac80211 instead of the current MAC stack written by Realtek. If the current driver were to be added to the kernel, it would be called r8192du.

@hanipouspilot
Copy link
Author

OK. I just pushed that driver to Ubuntu ppa. I will think how to get it smooth with namings. It is good to have all updates in your ppa, so I could just pull and repack them. Let's leave it as it is for a while then.

@lwfinger lwfinger force-pushed the master branch 2 times, most recently from e4f3e9a to f20ede8 Compare April 15, 2018 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants