Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme_default): fix omitted style for selected text in lv_textarea #7322

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vwheeler63
Copy link
Contributor

Selected text, even though it existed, was not showing up in TextArea examples. The bug was merely a style to show the text as selected was omitted from the Default Theme -- remedied with this PR.

Credit goes to @kisvegabor for finding the cause.

Resolves #7321

Notes

  • Update the Documentation if needed. n/a
  • Add Examples if relevant. n/a
  • Add Tests if applicable. n/a
  • If you added new options to lv_conf_template.h run lv_conf_internal_gen.py and update Kconfig. n/a
  • Run scripts/code-format.py (astyle v3.4.12 needs to installed by running cd scripts; ./install_astyle.sh) and follow the Code Conventions. Done.
  • Mark the Pull request as Draft while you are working on the first version, and mark is as Ready when it's ready for review. Done.
  • When changes were requested, re-request review to notify the maintainers. Done.
  • Help us to review this Pull Request! Anyone can approve or request changes.

Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Vic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text Selection in TextArea Not Showing Up
2 participants