-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cmake): fix installation with cmake --install #7161
Conversation
#7127 is merged. Is it ready to merge too? |
@kisvegabor I will attempt to add the missing commit before the Thursday evening, now busy with other things. |
5dd43c6
to
2628e2a
Compare
Let us know when it's ready to review. |
@kisvegabor Ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to tell for me if it's really better this way, but I trust your expertise 🙂
@kisvegabor It works with or without specifying a prefix, I've also removed the paths that are destined for executables. Since lvgl is a library, not an executable. |
fixes issue #6787 #6478
The
DESTINATION
arg of theinstall
directives located inenv_support/cmake/custom.cmake
being hardcoded to the default value ofCMAKE_INSTALL_PREFIX
resulted in a brokencmake_install.cmake
fileIf the user wants to use cmake to install lvgl headers and libraries to a custom location it can be done
at installation time with the following command
cmake --install build_dir --prefix /usr/custom/
Please note that currently
lvgl.pc
is not generated properly when--prefix
is used.There is an entire discussion on this subject in the cmake forums, the workaround is to set CMAKE_INSTALL_PREFIX at configuration time using the
-D
argumenthttps://discourse.cmake.org/t/how-to-generate-pc-pkg-config-file-supporting-prefix-of-the-cmake-install/4109