Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Use <script type="module"> to satisfy parcel #104

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

neuschaefer
Copy link
Contributor

Without this change, parcel (as run by npm run start) complains:

@parcel/transformer-js: Browser scripts cannot have imports or exports. Use a <script type="module"> instead.

To be fair, I don't understand web technology well enough to judge whether this is truly a good idea.

Without this change, parcel (as run by `npm run start`) complains:

  @parcel/transformer-js: Browser scripts cannot have imports or exports. Use a <script type="module"> instead.
@kisvegabor
Copy link
Member

I'm in constant fight with Node.JS, so every improvement is very welcome. 🙂
Thank you!

@kisvegabor
Copy link
Member

Please make it a normal PR (instead of draft), so I can merge it.

@neuschaefer neuschaefer marked this pull request as ready for review March 16, 2024 22:49
@neuschaefer
Copy link
Contributor Author

Please make it a normal PR (instead of draft), so I can merge it.

done, thanks for the reminder

@kisvegabor kisvegabor merged commit 7f9f29f into lvgl:master Mar 21, 2024
1 check passed
@kisvegabor
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants