Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1816 #1843

Merged
merged 7 commits into from
Sep 2, 2018
Merged

Issue 1816 #1843

merged 7 commits into from
Sep 2, 2018

Conversation

boehsermoe
Copy link
Member

@boehsermoe boehsermoe commented Sep 1, 2018 •
edited
Loading

close #1816

Q A
Is bugfix? no
New feature? yes
Breaks BC? no
Tests pass? yes
Fixed issues #1816

@coveralls
Copy link

coveralls commented Sep 1, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 55.69% when pulling d8a5e63 on boehsermoe:issue-1816 into 34668d1 on luyadev:master.

nadar
nadar suggested changes Sep 2, 2018
View reviewed changes
Copy link
Contributor

@nadar nadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good to me, what i am currently not sure:

'default/*' => '@app/views/mymodule/default',

The above mapping should find all actions in default controller in the @app/views/mymodule/defaul folder - is this covered in the code?

Just as additional information, the string helper (https://luya.io/api/luya-helpers-StringHelper) does also have some methods to check whether string starts/ends with wildcard.

core/base/Module.php Outdated Show resolved Hide resolved
@nadar
Copy link
Contributor

nadar commented Sep 2, 2018

Thank you!

@nadar nadar merged commit b327e02 into luyadev:master Sep 2, 2018
@boehsermoe boehsermoe deleted the issue-1816 branch October 12, 2018 16:33
nadar pushed a commit that referenced this pull request Aug 27, 2019
@boehsermoe @nadar
Issue 1816 (#1843)
bb4c5ac 
* View mapping for module action

* Unit Test for viewmapping

* Viewmap refactoring

* Viewpath refactoring

* Bugfix

* Changelog

* PHPdoc
nadar added a commit that referenced this pull request Aug 27, 2019
@nadar
new luya config (#1952)
ac27f9a 
* Update app-admin-module-assets.md

* ResponseCache using PageCache filter and mark $actionsCallable and
$actions as deprecated. #1827

* Update app-cmsproperties.md (#1828)

* Update app-cmsproperties.md

move comment

* Update app-cmsproperties.md

* Update app-cmsproperties.md

* Update app-admin-module.md (#1829)

* Add files via upload

* Update app-language.md

* Lazyload widget asset registration issue fixed when used in nested
context. closes #1830

* Create ngrest-api.md

* Update README.md

* Update ngrest-api.md

* Update ngrest-api.md

* Fixed issue with create url and complex composition patterns. #1831

* Update ngrest-api.md

* Update ngrest-api.md

* fix php doc

* add option for apiRules
luyadev/luya-module-admin#174

* Update app-translation.md

* Update app-translation.md

* Translation to English

* Update organisation.md

* Update organisation.md

* Update organisation.md

* Corrections. (#1836)

* Corrections.

* Update organisation.md

* Update organisation.md

* Update organisation.md

* make web bootstrap bc safe

* Update luya-package-dev.md

* Added new option `Composer::$hideDefaultPrefixOnly`  (#1834)

* Add `hideDefaultPrefixOnly` option

When enabled, composition prefixes will be hidden only for default language. Takes effect only when `hidden` option is disabled.

* Add Changelog record for `Composer::$hideDefaultPrefixOnly`

* Update app-translation.md

* Update app-translation.md

* Add `hideDefaultPrefixOnly` option

When enabled, composition prefixes will be hidden only for default language. Takes effect only when `hidden` option is disabled.

* Add Changelog record for `Composer::$hideDefaultPrefixOnly`

* add unit test

* Update CHANGELOG.md

* prepare release

* release bump

* remove comment

* api and headless update

* changed docs for new ActiveWindowFromWidget
luyadev/luya-module-admin#188

* Add body params to error report

* fix issue where only admin module is available and set as default route

* Update UPGRADE.md (#1839)

* auto convert mail message to alt body closes #1840

* Polish translation (#1841)

* Issue 1816 (#1843)

* View mapping for module action

* Unit Test for viewmapping

* Viewmap refactoring

* Viewpath refactoring

* Bugfix

* Changelog

* PHPdoc

* Translation Helper for dev (#1844)

* Translation helper controler

* PHPdoc

* PHPdoc

* Reformat

* Changelog #1844

* closes luyadev/luya-module-admin#185

* Fix issue where frontend rules have precedence over admin closes #1848

* cs fix and remove random aded char.

* prepare for release

* release bump

* add new truncate middle helper

* closes #1850, closes #1851

* Updated svg widget to enable svg > use implementation for svg sprites (#1852)

* Updated svg widget to enable svg > use implementation for svg sprites
* Added changelog entry; Added @SInCE tags

* add callable option for mock arguments closes #1853

* force cli env when applicationConsole is called #1856

* yii base object not available #1856

* Update organisation.md (#1858)

* Update app-module-urlrules.md

* Update app-module-urlrules.md

* Update app-module-urlrules.md

* docs and typos (closes #1812)

* update menu

* prepare for release

* bump release

* lock file update

* Update app-module-urlrules.md

* Update concept-depandsync.md (#1860)

* Update app-storage.md

* Update app-storage.md

* Update app-menu.md

* Update install-structures.md

* github markdown fixer

* Issue 1855 (#1861)

* Translation helper controler

* PHPdoc

* Unique url in Modul-Block context #1855

* Updated luya guideline GULP and CSS infos

* Updated Resources section

* Update luya-guideline.md

* Update app-module-urlrules.md

* Update app-module-urlrules.md

* fixed alt body cleanup closes #1859

* fixed alias use in renderLayout closes #1863

* Example for custom directives (#1865)

closes #1864

* Make ./luya serve command work out of the box (#1866)

Before:

```
$ ./luya serve
Document root "/home/cebe/dev/cebe.cc/luya/web" does not exist.
```

After:

```
$ ./luya serve
Server started on http://localhost:8080/
Document root is "/home/cebe/dev/cebe.cc/luya/public_html"
Quit the server with CTRL-C or COMMAND-C.

```

* add changelog #1866

* Update luya-package-dev.md

* Fix bug with word highlight in string helper. closes #1869

* prepare for release

* release bump

* Update luya-guideline.md

* string helper highlight word accepts list of words closes #1872

* string helper truncate middle no results output and strict compare closes #1870

* remove word highlight case sensitivity #1871

* Lazyload widget update (#1868)

* Initial update for base64 encode; Needs more work; #1867
* Updated widget
* Rewritten lazyload js and added new placeholderSrc. Updated lazyload docs; #1867
* Updated widget and documentation for better base64 usability; Added @SInCE tags; #1867
* Updated styles for placeholder div
* Fixed an issue that occurs if two types of lazyloading are used on one page
* Added package.json; Added Karma conf; Added first basic LazyLoad tests
* Update LazyLoad.php

* Updated LazyLoading to improve placeholder behaviour; Updated tests

* Fixed small issue with placeholder height

* Added LocalBusiness Json-Ld. Fixed Event Json-Ld, and TypeHinting. #1872

* add new schema org entries #1872

* remove empty values by default

* add new guide section for active buttons

* fix local business inheritance, rating, aggregate rating and postal address. #1872

* fix range issue

* Update app-storage.md

* use debug message isntead of info

* Extend guide "Admin permission" (#1873)

* Update app-storage.md (#1874)

*  Correct parameter order for help (#1875)

* Translation helper controler

* PHPdoc

* Correct parameter order for help

* Update RepoController.php

* change empty/null value handling

* update curl version constraint

* prepare for release

* bump version

* Update app-blocks.md

* Create app-admin-module-api.md

* Update README.md

* Update app-admin-module-api.md (#1880)

* Update app-admin-module-api.md

* Update app-admin-module-api.md

* Update app-admin-module-api.md

* Update app-admin-module-api.md

* Quote highlight word

* Update RangeValue.php

* Add requires.push info

liberosoft/luyawysiwyg#1

* Url module controller context fix (#1877)

* Translation helper controler

* PHPdoc

* Correct parameter order for help

* Bugfix with language switcher #1876

* Unit test fix

* Refactoring urlReplaceModule

* Changelog

* Typo

* Documentation for block preview  (#1884)

* Documentation for block preview luyadev/luya-module-cms#83

* Documentation for block preview luyadev/luya-module-cms#83

* change naming

* Update app-admin-module-dashboardobjects.md

* Update app-admin-module-dashboardobjects.md

* Updated lazyload: Added function refetchElements to force lazyload to handle new images (for example in async loaded content)

* LazyLoading: Small fix to prevent issues with adding new images to existing page

* LazyLoad: Fixed small issue with id/index

* closes #1888 closes #1887

* Changelog update; Closes #1889

* Fixed issue with lazyloading; #1889

* Fix issue where current url rule appends path param. closes #1885

* add originalArgs for request route

* add php 7.3

* allow php 7.3 to fail

* Correct a typing error (#1893)

* add email tag obfuscation #1895

* change unit tests, encoding ensure mailto

* fix html class name

* fix email tag obfuscation

* ensure obfuscation encoding #1895

* Update concept-depandsync.md

* PHPDoc correction (#1896)

Corrected class (changed from old deprecated to new Behavior)

* fix issue with yii constants closes #1897

* fix telephone link exception closes #1898

* Update Formatter.php (#1899)

Typo

* Fix Composition::createRouteEnsure (#1902)

* Fix Composition::createRouteEnsure

with hideDefaultPrefixOnly == true composition component should not hide lang code if current lang *is* default but the url being constructed *is not* (e.g. LanguageSwitcher)

* CHANGELOG entry

* fixed variable declaration and psr isset

* revert Yii include hirarchy #1897

* use basename for mail attachment closes #1900

* Update app-blocks.md

* refactor resolver #1905

* add $expectedValues for valid language testing #1905

* add not found catch in url manager #1905

* add active window buttons to doc

* Update install-upgrade.md

* Issue 1907 (#1908)

* add test case and new regex #1907

* add tag sub value escapeing #1907

* add changelog #1907

* Update TagParser.php

* prepare for release

* release bump

* Delete ISSUE_TEMPLATE.md

* Delete PULL_REQUEST_TEMPLATE.md

* Update luya-collaboration.md

* Fix StringHelper::highlightWord delimiter issue closes #1909

* Fixed resized callback in lazyload js; Closes #1910

* Update organisation.md

* Fixed bug in ArrayHelper::searchColumn() when using assoc arrays. closes #1911

* prepare for release

* prepare packages for semver

* use parent unlink class for file helper

* update git wrapper dependencies

* add new trait helper #1912

* fix regex issue with php 7.3

* add php 7.3

* add deprecated info

* fix robots filter session problem #1914

* change constraint

* remove fixed platform

* ignore platform requirements

* move to require dev

* use version 1 of git wrapper package

* fix robot filter bug

* ignore platform reqs

* add platform

* add robot tests

* merge variables

* change min requirement

* update lock file

* Update ngrest-plugins.md (#1915)

There is an mystype in renderList method

* change loader path finder

* use relative path for config in bin closes #1799

* Update luya-guideline.md

* Update ngrest-activewindow.md

* Update app-admin-module-assets.md

* Update app-admin-module-assets.md

* prepare for release

* add changelog section

* release bump

* Update install-upgrade.md

* Formating inproved (#1919)

* add resolveHostInfo #1921

* admin 2.0 draft

* Update note_admin-2.0.0.md

* Update note_admin-2.0.0.md

* use new ds seperator

* pools guide luyadev/luya-module-admin#236

* add images for admin 2.0 release note

* change image paths

* text updates

* Update note_admin-2.0.0.md (#1922)

* fixed issue with binary

* add notifications text draft

* update news

* prepare for release

* update lock file

* update changelog

* release bump

* allow git wrapper version 1

* Update install-upgrade.md

* add new object helpers #1925

* use static functions

* fix bug in fileToName method

* add new console command context check #1927

* use fix class path #1927

* Update luya-package-dev.md

* use code climate

* fixed issue with relativ links in link tag #1931

* add travis unit test verbosity

* ensure object helper method does not throw exceptio

* add invalid param exception to try catch block

* prepare for release

* release bump

* Update app-storage.md

* Update deploy file with best practises and example (#1934)

* Update deploy file with best practises and example

* Update concept-depandsync.md

* Update concept-depandsync.md

* add rest helper

* Update text on page properties (#1935)

* Update text on page properties

Some typo's, explanation on where to find these properties in the CMS part and code on how to use the properties in a view.

* Update app-cmsproperties.md

* Travis mysql connection failed (#1937)

* Translation helper controler

* PHPdoc

* Correct parameter order for help

* Documentation for block preview luyadev/luya-module-cms#83

* Revert PHP doc

* Travis mysql connection failed

* fix rest helper with static key word

* fix use statement

* add cleanHost and domain methods closes #1940

* add infos to error handler #1939

* filter empty array values

* check if file is empty

* add changelog closes #1941

* add subdomain test

* add php doc

* prepare changelog

* add test

* use setFrom() #1942

* version bump

* allow to extend composite auth methods

* Update install-problems.md

* add optional auth actions to rest behavior

* Update CHANGELOG.md

* Update ngrest-plugin-select.md

* Update ngrest-plugin-select.md

* Update ngrest-plugin-select.md

* Update ngrest-plugin-select.md

* Update ngrest-plugin-select.md

* add bootstrap, add changelog, add docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadar nadar nadar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enabled useAppViewPath require copy all view under @app/views
3 participants
@boehsermoe @coveralls @nadar