Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BC] Base Active Record remove $extraFields variable #907

Closed
nadar opened this issue Jun 23, 2016 · 0 comments
Closed

[BC] Base Active Record remove $extraFields variable #907

nadar opened this issue Jun 23, 2016 · 0 comments
Assignees
@nadar
Labels
architecture
Milestone
1.0.0-beta8

Comments

@nadar
Copy link
Contributor

nadar commented Jun 23, 2016

The luya specific variable $extraFields may end into confusion, instead always use the override option of extraFields(). BC-BREAK
@nadar nadar added this to the 1.0.0-beta8 milestone Jun 23, 2016
@nadar nadar self-assigned this Jun 23, 2016
nadar added a commit that referenced this issue Jun 23, 2016
@nadar
Removed the public attribute $extraFields in order to prevent
066a60e 
confusings. Override `extraFields()` instead in
`admin\ngrest\base\Model`. #907
@nadar nadar changed the title Base Active Record remote $extraFields variable Base Active Record remove $extraFields variable Jun 29, 2016
@nadar nadar closed this as completed Aug 4, 2016
@nadar nadar changed the title Base Active Record remove $extraFields variable [BC] Base Active Record remove $extraFields variable Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadar nadar

Labels
architecture
Projects
None yet
Milestone
1.0.0-beta8
Development

No branches or pull requests
1 participant
@nadar