Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background class for segmentation if pixels without annotations found #191

Merged
merged 8 commits into from
Oct 24, 2024

Conversation

sokovninn
Copy link
Member

@sokovninn sokovninn commented Oct 23, 2024

This pull request introduces logic to handle unassigned pixels in segmentation masks.

Tested with a luxonis-train segmentation model training.

@sokovninn sokovninn requested a review from a team as a code owner October 23, 2024 15:52
@sokovninn sokovninn requested review from kozlov721, klemen1999, tersekmatija and conorsim and removed request for a team October 23, 2024 15:52
@github-actions github-actions bot added fix Fixing a bug release New version release labels Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.12%. Comparing base (6bcbb11) to head (69e23f0).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   92.33%   92.12%   -0.22%     
==========================================
  Files          79       79              
  Lines        4161     4176      +15     
==========================================
+ Hits         3842     3847       +5     
- Misses        319      329      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

luxonis_ml/data/loaders/luxonis_loader.py Outdated Show resolved Hide resolved
@sokovninn sokovninn merged commit f29cec5 into main Oct 24, 2024
10 checks passed
@sokovninn sokovninn deleted the fix/auto-seg-background branch October 24, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing a bug release New version release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants