Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LuxonisParser - RoboFlow URL Support #189

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Conversation

kozlov721
Copy link
Collaborator

@kozlov721 kozlov721 commented Oct 7, 2024

  • Added support for downloading data directly from RoboFlow when using LuxonisParser
  • URL is expected to look like: roboflow://workspace/project/version/format
  • Added ROBOFLOW_API_KEY to luxonis_ml.utils.Environ

Example:

luxonis_ml data parse 'roboflow://joseph-nelson/thermal-dogs-and-people/6/voc' -n thermal-dogs -t voc

@kozlov721 kozlov721 requested a review from a team as a code owner October 7, 2024 20:43
@kozlov721 kozlov721 requested review from klemen1999, tersekmatija and conorsim and removed request for a team October 7, 2024 20:43
@github-actions github-actions bot added enhancement New feature or request utils Changes affecting luxonis_ml.utils subpackage labels Oct 7, 2024
@kozlov721 kozlov721 added the data Changes affecting luxonis_ml.data subpackage label Oct 7, 2024
@github-actions github-actions bot added the DevOps Changes related to DevOps label Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 47.05882% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@4fa0a02). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
luxonis_ml/data/parsers/luxonis_parser.py 30.76% 18 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #189   +/-   ##
======================================
  Coverage       ?   92.05%           
======================================
  Files          ?       79           
  Lines          ?     4156           
  Branches       ?        0           
======================================
  Hits           ?     3826           
  Misses         ?      330           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tersekmatija tersekmatija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments to minimize the required dependencies.

@kozlov721 kozlov721 merged commit 6bcbb11 into dev Oct 8, 2024
12 checks passed
@kozlov721 kozlov721 deleted the feature/roboflow-support branch October 8, 2024 21:56
@kozlov721 kozlov721 mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Changes affecting luxonis_ml.data subpackage DevOps Changes related to DevOps enhancement New feature or request utils Changes affecting luxonis_ml.utils subpackage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants