Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lit/luvi versions to latest for testing #1063

Closed
wants to merge 4 commits into from

Conversation

squeek502
Copy link
Member

This is only for CI purposes. I'll rebase this branch as we fix things, so our goal is to make the CI pass on this branch.

See #1058 & #1060

@rphillips
Copy link
Member

Looks like lit may need a lua-openssl tweak.

@squeek502
Copy link
Member Author

Looks like lit may need a lua-openssl tweak.

Yep, needs luvit/lit#257

@squeek502
Copy link
Member Author

Published a fixed lit (3.7.3) and rebased to include #1065

@zhaozg
Copy link
Member

zhaozg commented Jun 29, 2019

please rebase on #1078 and relaunch CI.

@squeek502
Copy link
Member Author

Rebased on latest master and merged #1078 for testing

@zhaozg
Copy link
Member

zhaozg commented Jun 30, 2019

The fail narrow

Uncaught Error: C:/projects/luvit/tests/test-tls-connect-session-reuse.lua:69: assertion failed!
stack traceback:
	[C]: in function 'assert'
	C:/projects/luvit/tests/test-tls-connect-session-reuse.lua:69: in function 'handler'
	C:/projects/luvit/deps/core.lua:248: in function 'emit'
	C:/projects/luvit/deps/tls/common.lua:238: in function 'handler'
	C:/projects/luvit/deps/core.lua:248: in function 'emit'
	C:/projects/luvit/deps/tls/common.lua:432: in function 'handshake'
	C:/projects/luvit/deps/tls/common.lua:403: in function <C:/projects/luvit/deps/tls/common.lua:392>
	[C]: in function 'run'
	C:/projects/luvit/tests/libs/tap.lua:79: in function <C:/projects/luvit/tests/libs/tap.lua:64>
	[C]: in function 'xpcall'
	C:/projects/luvit/tests/libs/tap.lua:64: in function 'run'
	C:/projects/luvit/tests/libs/tap.lua:165: in function 'tap'
	C:\projects\luvit\tests\run.lua:42: in function 'fn'
	[string "bundle:deps/require.lua"]:310: in function 'require'
	[string "bundle:main.lua"]:118: in function 'main'
	[string "bundle:init.lua"]:49: in function <[string "bundle:init.lua"]:47>
	[C]: in function 'xpcall'
	[string "bundle:init.lua"]:47: in function 'fn'
	[string "bundle:deps/require.lua"]:310: in function <[string "bundle:deps/require.lua"]:266>
Command exited with code -4
# Starting Test: tls-connect-session-reuse - tls connect session reuse test
'server listening at:'	12456
'client connected'
'server accepted'	1
Uncaught Error: ...ild/luvit/luvit/tests/test-tls-connect-session-reuse.lua:69: assertion failed!
stack traceback:
	[C]: in function 'assert'
	...ild/luvit/luvit/tests/test-tls-connect-session-reuse.lua:69: in function 'handler'
	/Users/travis/build/luvit/luvit/deps/core.lua:248: in function 'emit'
	/Users/travis/build/luvit/luvit/deps/tls/common.lua:238: in function 'handler'
	/Users/travis/build/luvit/luvit/deps/core.lua:248: in function 'emit'
	/Users/travis/build/luvit/luvit/deps/tls/common.lua:432: in function 'handshake'
	/Users/travis/build/luvit/luvit/deps/tls/common.lua:403: in function </Users/travis/build/luvit/luvit/deps/tls/common.lua:392>
	[C]: in function 'run'
	/Users/travis/build/luvit/luvit/tests/libs/tap.lua:79: in function </Users/travis/build/luvit/luvit/tests/libs/tap.lua:64>
	[C]: in function 'xpcall'
	/Users/travis/build/luvit/luvit/tests/libs/tap.lua:64: in function 'run'
	/Users/travis/build/luvit/luvit/tests/libs/tap.lua:165: in function 'tap'
	/Users/travis/build/luvit/luvit/tests/run.lua:42: in function 'fn'
	[string "bundle:deps/require.lua"]:310: in function 'require'
	/Users/travis/build/luvit/luvit/main.lua:118: in function 'main'
	/Users/travis/build/luvit/luvit/init.lua:49: in function </Users/travis/build/luvit/luvit/init.lua:47>
	[C]: in function 'xpcall'
	/Users/travis/build/luvit/luvit/init.lua:47: in function 'fn'
	[string "bundle:deps/require.lua"]:310: in function <[string "bundle:deps/require.lua"]:266>
'server accepted'	2
'server closed'
ok 190 tls-connect-session-reuse - tls connect session reuse test

@zhaozg
Copy link
Member

zhaozg commented Jun 30, 2019

curl/curl#3271 says TLS1.3 session reuse don't same with old version. I wll do some work on it.

@zhaozg
Copy link
Member

zhaozg commented Jul 2, 2019

ok 190 tls-connect-session-reuse - tls connect session reuse test on linux/mac
ok 174 tls-connect-session-reuse - tls connect session reuse test on windows

@squeek502
Copy link
Member Author

squeek502 commented Jul 2, 2019

Nice work, rebased on latest master.

EDIT: Failing childprocess tests on Windows seem to be the last thing we need to fix.

@zhaozg
Copy link
Member

zhaozg commented Jul 3, 2019

And need to add uv.spawn for windows in luv

@zhaozg
Copy link
Member

zhaozg commented Jul 15, 2019

@rphillips
Copy link
Member

Looks like the test machines may not have enough RAM or swap to run the test:

nodejs/node#25382

@zhaozg
Copy link
Member

zhaozg commented Jul 15, 2019

I can do some test on real windows box, in this weekend.

@zhaozg
Copy link
Member

zhaozg commented Jul 22, 2019

libuv/libuv#2133 A tiny uv_spawn call from a large process attempts to reserve as much memory as the large process. For example, when Node.js is using at least half of the otherwise-available memory, exec() causes spawn ENOMEM

That explain why luv direct uv.spawn success but luvi/luvit fails.

@squeek502
Copy link
Member Author

Bumping luv to latest might get all tests to pass now, see luvit/luv#386 for the likely cause of the ENOMEM errors on Windows.

@squeek502
Copy link
Member Author

I think we've got everything working again 🎉. Not sure why the https-client test failed here, but it seems random and I can't reproduce it, so I guess we'll just need to look into it if it becomes a problem.

I'm going to rebase this branch onto latest master for one last test and then we can move forward with a new Luvit release with the latest Luvi.

@squeek502
Copy link
Member Author

Closing in favor of #1098

@squeek502 squeek502 closed this Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants