introduce miniz submodule #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If richgel999/miniz#315 be accept, we can change miniz repo to https://github.com/richgel999/miniz |
Closed
|
richgel999/miniz#315 has been merged, miniz repo back to https://github.com/richgel999/miniz |
squeek502
reviewed
Jul 10, 2024
| @@ -132,8 +132,16 @@ if (WITH_LUA_ENGINE STREQUAL Lua) | |||
| endif () | |||
|
|
|||
| include(LuaAddExecutable) | |||
|
|
|||
| # TODO: define MINIZ_NO_STDIO for small size | |||
There was a problem hiding this comment.
Is this important to do before merging?
There was a problem hiding this comment.
No, I hope to make PR to miniz to support MINIZ_NO_STDIO build with cmake later, miniz cmake without MINIZ_NO_STDIO options now. So let's merge, and fix this TODO after miniz with this feature.
There was a problem hiding this comment.
The miniz PR is richgel999/miniz#316
squeek502
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.