Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Make usage of LUA_PATH in LuaJITAddExecutable depend on it being set #258

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

squeek502
Copy link
Member

Should fix #242

Let me know if this'll work for you @carlocab

@carlocab
Copy link
Contributor

carlocab commented Jan 6, 2022

I believe this should work, but let me test it out later.

One thing I'm confused about: the CMake variable LUA_PATH is populated by the environment variable LUA_PATH. luajit should already be reading LUA_PATH from the environment and using that value when it's set, so it seems redundant to me to have to call luajit with LUA_PATH=....

What am I missing here?

@squeek502
Copy link
Member Author

I'm also unclear on that, but wanted to leave it alone just in case. Here's where it was added: #122

@zhaozg
Copy link
Member

zhaozg commented Jan 6, 2022

I have not ideas about this. Maybe found we need find more direct way.

@squeek502 squeek502 merged commit 06a5c66 into luvit:master Jan 11, 2022
@carlocab
Copy link
Contributor

Thanks @squeek502!

@zhaozg
Copy link
Member

zhaozg commented Jan 15, 2022

My mistake

I found the similarly problem, when I do coveralls test lua-openssl. [here]https://github.com/zhaozg/lua-openssl/runs/4824775420?check_suite_focus=true#step:5:599

This maybe a bug in ubuntu with apt install luajit libluajit-5.1-dev, https://github.com/zhaozg/lua-openssl/actions/runs/1700632752/workflow#L19

After build luajit from git source, this issue disappeared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure with custom LuaJIT (OpenResty fork)
3 participants