Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac/Linux deploy failing #225

Closed
squeek502 opened this issue Jan 25, 2020 · 3 comments
Closed

Mac/Linux deploy failing #225

squeek502 opened this issue Jan 25, 2020 · 3 comments

Comments

@squeek502
Copy link
Member

https://travis-ci.org/luvit/luvi/builds/641610846

Not really sure what's going wrong. Is it this?

Fetching submodule deps/lua-openssl
Fetching submodule deps/luv
fatal: remote error: upload-pack: not our ref b0e9de051656471a8e12bf1e576285642b02c3e1c886cb4ade983dadedc721d9f0071924d5aee
From https://github.com/zhaozg/lua-openssl
 * branch            80896f0f3914dffe4228d8d8dd7e2c68e329c88c -> FETCH_HEAD
The command "git fetch --unshallow" exited with 1.

On Linux there's also this:

In file included from /luvi/deps/luv/deps/luajit/src/ljamalg.c:68:0:
/luvi/deps/luv/deps/luajit/src/lj_opt_fold.c: In function 'lj_opt_fold':
/luvi/deps/luv/deps/luajit/src/lj_opt_fold.c:2475:18: warning: implicit declaration of function 'fold_hashkey'; did you mean 'hashkey'? [-Wimplicit-function-declaration]
     uint32_t h = fold_hashkey(k);
                  ^~~~~~~~~~~~
                  hashkey
/luvi/deps/luv/deps/luajit/src/lj_opt_fold.c:2476:19: error: 'fold_hash' undeclared (first use in this function); did you mean 'fold_prof'?
     uint32_t fh = fold_hash[h];  /* Lookup key in semi-perfect hash table. */
                   ^~~~~~~~~
                   fold_prof
/luvi/deps/luv/deps/luajit/src/lj_opt_fold.c:2476:19: note: each undeclared identifier is reported only once for each function it appears in
In file included from /luvi/deps/luv/deps/luajit/src/lj_jit.h:10:0,
                 from /luvi/deps/luv/deps/luajit/src/lj_trace.h:12,
                 from /luvi/deps/luv/deps/luajit/src/lj_gc.c:27,
                 from /luvi/deps/luv/deps/luajit/src/ljamalg.c:31:
/luvi/deps/luv/deps/luajit/src/lj_opt_fold.c:2478:29: error: 'fold_func' undeclared (first use in this function); did you mean 'FoldFunc'?
       ref = (IRRef)tref_ref(fold_func[fh >> 24](J));
                             ^
/luvi/deps/luv/deps/luajit/src/lj_ir.h:487:33: note: in definition of macro 'tref_ref'
 #define tref_ref(tr)  ((IRRef1)(tr))
                                 ^~

Only happens during deploy, not during the regular CI steps.

@zhaozg
Copy link
Member

zhaozg commented Jan 25, 2020

I will look into it

squeek502 added a commit to squeek502/luv that referenced this issue Jan 29, 2020
Addresses the "'fold_hash' undeclared" compile errors in luvit/luvi#225

See also torch/luajit-rocks#39
@squeek502
Copy link
Member Author

This should fix the Linux error, not sure about Mac: luvit/luv#454

squeek502 added a commit to squeek502/luvi that referenced this issue Jan 29, 2020
Should hopefully address luvit#225
@squeek502
Copy link
Member Author

Fixed by luvit/luv#454 / #226

Timothy- pushed a commit to luvitred/luv that referenced this issue Apr 17, 2020
Addresses the "'fold_hash' undeclared" compile errors in luvit/luvi#225

See also torch/luajit-rocks#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants