Add span tag wrapping text for vsDialog component #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simply adds a span wrapper around the text passed as a property, allowing users to do things like line breaks `$vs.dialog({ text: "Some \n line." })` and properly formatting them with for example `white-space: pre-line` targeting in their css the `span` inside the `div` avoiding weird white spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply adds a span wrapper around the text passed as a property, allowing users to do things like line breaks
$vs.dialog({ text: "Some \n line." })and properly formatting them with for examplewhite-space: pre-linetargeting in their css thespaninside thedivavoiding weird white spaces.