refactor of SatisfyingAssignment as type alias of WitnessCS #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobez
changed the title
jobez
changed the title
huitseeker
force-pushed
the
refactor/dedup_SatisfyingAssignment_from_WitnessCS
branch
from
858338f to
b8b4c0e
Compare
huitseeker
approved these changes
Nov 5, 2023
arthurpaulino
approved these changes
Nov 6, 2023
This was referenced Nov 6, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 9, 2023
* chore: Update bellpepper and neptune dependencies - Updated `bellpepper-core` and `bellpepper` dependencies to version `0.4.0` - Upgraded `neptune` dependency to version `13.0.0` * refactor of SatisfyingAssignment as type alias of WitnessCS (#89) * initial refactor of WitnessCS with ex of new constr generic changes * explicit type information for usages of `SatisfyingAssignment::new` * use `scalar_` public getters for the aliased WitnessCS * go back to `_assignment` public fields * remove reference --------- Co-authored-by: johann bestowrous <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion: #77 and pending the merging of: lurk-lang/bellpepper#48
We refactor SatisfyingAssignment as an alias of WitnessCS, parameterized with the Group's associative type of Scalar. This change introduces a level of genericity, which means we need to add explicit type information during instantiation in order to resolve compiler ambiguity.
i.e., We refactor
SatisfyingAssignment::new()calls with explicit type information that the compiler needs to construct an instance ofWitnessCSi.e.
SatisfyingAssignment::<G>::new()otherwise we would see errors like: