refactor: add missing Debug implementations #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored iterated zip operations in batch evaluation verification function in `src/spartan/snark.rs` - Used `zip_with!` macro to enhance code readability and maintainability
- Enhanced the efficiency of polynomial evaluation in `prove` function in `src/spartan/snark.rs` by eliminating needless cloning.
- `Debug` trait added across multiple files to enhance log and error handling capacity; applies to structures like `ProverKey`, `VerifierKey`, `R1CSWithArity`, `NovaPublicParameters`, `CompressedSNARK`, and others. - Expanded `Debug` trait implementation to more complex structures like `CircuitDigests`, `PublicParams`, associated types in `ROTrait` and `ROCircuitTrait`, and several structures in the `spartan` and `gadgets` module. - An additional project-wide compilation check for missing `Debug` implementations has been added to cargo build settings.
huitseeker
force-pushed
the
streamline
branch
from
50a7dd6 to
ee737a4
Compare
mpenciak
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing
Debugimplementations, along with fixing some annoying things I found while working on something else.