Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: some installed deps are not needed #309

Closed
github-actions bot opened this issue Feb 10, 2024 · 1 comment
Closed

chore: some installed deps are not needed #309

github-actions bot opened this issue Feb 10, 2024 · 1 comment

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2024

Some dependencies specified in Cargo.toml are not needed.

Check the unused dependencies sanity check workflow for details.

This issue was raised by the workflow at https://github.com/lurk-lab/ci-workflows/tree/main/.github/workflows/unused-deps.yml.

Note
If this is a false positive, please refer to the cargo-udeps docs on how to ignore the dependencies.

huitseeker added a commit to huitseeker/arecibo that referenced this issue Feb 12, 2024
- Shifted `pprof` from `dev-dependencies` to `dependencies` for non-wasm32 targets to optimize benchmarking builds.
- Introduced "flamegraph" feature to include `pprof` during benchmarking.
- Closes lurk-lang#309
github-merge-queue bot pushed a commit that referenced this issue Feb 12, 2024
* refactor: Refactor public param digest tests in lib.rs

- Refactored test functions within the tests module for greater efficiency and readability.
- Removed `DlogGroup` trait usage within the `test_pp_digest_with` function.
- Simplified `test_pp_digest` function by removing redundant circuit instantiation.

* chore: Upgrade Rust Toolchain Version to 1.76.0

- Upgraded the rust toolchain version from `1.75` to `1.76.0` in `rust-toolchain.toml` file.
- Closes #307

* chore: Refactor pprof dependency

- Shifted `pprof` from `dev-dependencies` to `dependencies` for non-wasm32 targets to optimize benchmarking builds.
- Introduced "flamegraph" feature to include `pprof` during benchmarking.
- Closes #309

* refactor: Refactor computation in sumcheck module

- Streamlined calculation of evaluation points in `compute_eval_points_quad` and `compute_eval_points_cubic_with_additive_term` functions within `src/spartan/sumcheck/mod.rs`.
@huitseeker
Copy link
Contributor

Closed in #319

huitseeker pushed a commit to huitseeker/arecibo that referenced this issue Feb 17, 2024
* rename and introduce checks about length

* introduce a test about public IO
huitseeker pushed a commit to huitseeker/arecibo that referenced this issue Feb 17, 2024
* rename and introduce checks about length

* introduce a test about public IO
huitseeker pushed a commit to huitseeker/arecibo that referenced this issue Feb 17, 2024
* rename and introduce checks about length

* introduce a test about public IO
huitseeker pushed a commit that referenced this issue Feb 17, 2024
* rename and introduce checks about length

* introduce a test about public IO
huitseeker pushed a commit to huitseeker/arecibo that referenced this issue Feb 19, 2024
* rename and introduce checks about length

* introduce a test about public IO
github-merge-queue bot pushed a commit that referenced this issue Feb 20, 2024
* update README; update version (#303)

* Miscellaneous improvements (details in commit messages) (#308)

* move KZG engine to provider module; update paths everywhere

* add a sparse matrix entry only if the coefficient is non-zero; update digests

* move test code to place where it is used

* move asm to default and add a note

* update constants

* update link

* simplify test_pp_digest

* chore: update expect tests

* Improvements to error handling and naming (#309)

* rename and introduce checks about length

* introduce a test about public IO

* chore: remove needless annotation

---------

Co-authored-by: Srinath Setty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant