chore: Optimize public parameter serialization with bincode #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winston-h-zhang
previously approved these changes
May 5, 2023
- Introduce `bincode` dependency to replace `serde_json` in serialization and deserialization - Improve error message for cache deserialization issues in `public_parameters` module
huitseeker
force-pushed
the
serde_json_to_bincode
branch
from
cbd592e to
05261c6
Compare
samuelburnham
approved these changes
May 5, 2023
porcuquine
approved these changes
May 5, 2023
There was a problem hiding this comment.
Nice, slap a --release in there per #392 and we'll really be cooking with gas!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bincodedependency to replaceserde_jsonin serialization and deserializationpublic_parametersmoduleContributes to #387 : reduces the reading time by ~2x (1000s to 500s on my machine), the cache size by ~2x (2.1GB to 1.1GB). Hopefully this is just the start.