fix double lock

[chipitsine]

found by coverity

754
2. lock: SQLFetch locks hStmt->mutex.[show details]
3. Condition (ret = SQLFetch(hStmt)) == 0, taking false branch.
CID 442426:(#2 of 4):Double lock (LOCK) [ "select issue" ]
755 while ( (ret = SQLFetch( hStmt )) == SQL_SUCCESS ) /* ROWS */

[chipitsine]

@lurcher , can you please review this ?

coverity yells loudly that thread_protect is met without thread_release.

also, do we have to put thread_protect in the very beginning ?

[lurcher]

From my reading of the current code, the thread_protect at SQLFetch.c line 172 is matched by the thread_release in function_return_nodrv and function_return

[lurcher]

Sorry, but that doesn't make any sense. Both SQL_HANDLE_STMT and IGNORE_THREAD are preprocessor defines. You are saying "if ( 3 != (-1))" which will always be true. Am I missing something.

[chipitsine]

please ignore, I'm experimenting with coverity.

comparing two constants does not make sense indeed

[chipitsine]

ok, seems we just have to mark it as intentional and ignore