Fix for parsing use_h2c config #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my [luraproject#694](luraproject#694) I fixed issued with h2c support and CORS. There was small bug which slipped through code review. New config field does not use correct struct tag. Changed `json` to `mapstructure`. Signed-off-by: Antonije Ivanovic <[email protected]>
anivanovic
force-pushed
the
antonije/fix_parsing_h2c_config
branch
from
b74ca93 to
396a97c
Compare
|
Thank you @anivanovic ! |
taik0
approved these changes
Nov 16, 2023
|
This pull request was marked as resolved a long time ago and now has been automatically locked as there has not been any recent activity after it. You can still open a new issue and reference this link. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #694 I fixed issued with h2c support and CORS. There was small bug which slipped through code review. New config field does not use correct struct tag.
Changed
jsontomapstructure.