Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be panic with gin(v1.1.5-0.20170702092826-d459835d2b07) as below
so when I config in lura with gin as below
I will get the same panic, so, I just upgrade gin to lastest version.
We can get a few clues with this issue and PR. Actuall, the problem has been fixed in Gin,but, we can't get the client ip correctly, becasue as below
lura doesn't set the
trustedCIDRs
with gin, so, I just use the functionmux.ClientIP
instead, and it does work!