Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS-189] Color Token 업데이트 & Button/ToggleButton 컴포넌트 컬러 업데이트 #174

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

Jiyeon-lunit
Copy link
Contributor

@Jiyeon-lunit Jiyeon-lunit commented Jun 10, 2024

Jira : DS-189
-> relate 된 이슈들 이번 pr 에서 전부 진행 완료

Description

  • 새로운 Color Token 업데이트

    • border_light
    • border_medium
    • btn_selected_tertiary_bg
    • btn_selected_tertiary_text
  • 기존 Color Token 색상 업데이트

    • btn_secondary_bg
    • btn_selected_secondary_text
    • link_primary
    • link_hover
    • link_visited
    • hover
  • Button, ToggleButton 컴포넌트의 secondary 관련 컬러 업데이트

@Jiyeon-lunit Jiyeon-lunit self-assigned this Jun 10, 2024
Copy link

github-actions bot commented Jun 10, 2024

Copy link
Contributor

@LTakhyunKim LTakhyunKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

토큰에 대한 color 값 업데이트 및 사용하지 않는 component token 대체 작업 확인 완료했습니다.
구두로 말씀해주신 것처럼 앞으로 사용하지 않을 토큰의 경우 deprecated 처리와 같이 사용자가 인지할 수 있는 무언가를 결정하는 논의가 필요해보이네요.

고생 많으셨습니다.

@Jiyeon-lunit Jiyeon-lunit merged commit 4683840 into main Jun 13, 2024
5 checks passed
@Jiyeon-lunit Jiyeon-lunit deleted the DS-189-update-color-token branch June 13, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants