New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DS-155] Color System Docs mdx 추가 #165

Merged

Jiyeon-lunit merged 5 commits into main from DS-155-Docs-Color

Mar 25, 2024

Contributor

Jiyeon-lunit commented Mar 12, 2024 •

edited by jira bot

Loading

JIRA : DS-155

Color System & Token 을 설명하는 Storybook Docs 추가
읽는 사람이 이해가 편하도록 한글로 작성. 영문 버전이 필요하면 추후 작업하겠습니다.
예제는 추후 더 추가할 예정


          docs: add Color System Docs mdx

c3e607e

Jiyeon-lunit requested a review from a team

March 12, 2024 09:33

Jiyeon-lunit self-assigned this

github-actions bot commented Mar 12, 2024 •

edited

Loading

Design System Storybook: https://62d7d1f2efc8a1e364b5e5e8-yqvzkxljot.chromatic.com/

deminoth reviewed

View reviewed changes

packages/design-system/src/stories/foundation/colors/Docs.mdx Outdated Show resolved Hide resolved

deminoth reviewed

View reviewed changes

packages/design-system/src/stories/foundation/colors/Docs.mdx Outdated Show resolved Hide resolved

deminoth reviewed

View reviewed changes

packages/design-system/src/stories/foundation/colors/Docs.mdx Outdated Show resolved Hide resolved

Member

deminoth commented Mar 14, 2024

읽는 사람이 이해가 편하도록 한글로 작성. 영문 버전이 필요하면 추후 작업하겠습니다.

문서가 없는 것 보다는 한글 문서가 있는 쪽이 압도적으로 좋습니다! 하지만 주로 읽는 대상은 XE팀 외부의 개발자들이 되었으면 좋겠네요..

LTakhyunKim reviewed

View reviewed changes

packages/design-system/src/stories/foundation/colors/Docs.mdx Outdated Show resolved Hide resolved

LTakhyunKim reviewed

View reviewed changes

packages/design-system/src/stories/foundation/colors/Docs.mdx Show resolved Hide resolved

LTakhyunKim reviewed

View reviewed changes

packages/design-system/src/stories/foundation/colors/Docs.mdx Outdated Show resolved Hide resolved

LTakhyunKim reviewed

View reviewed changes

packages/design-system/src/stories/foundation/colors/Docs.mdx Outdated Show resolved Hide resolved

Jiyeon-lunit added 4 commits

March 25, 2024 13:58


          docs(color): delete br tag in docs

2f54019


          docs(color): update text

7f56a4f


          docs(color): update example code

a06fa82


          docs(color): update contents

603cb70

LTakhyunKim approved these changes

View reviewed changes

Contributor

LTakhyunKim left a comment

마지막으로 변경해주신 내용까지 확인했습니다.
상세하게 내용 기입이 되어 있어 이해하는게 큰 무리는 없을 것으로 예상되네요!
고생 많으셨습니다.
👍

Jiyeon-lunit merged commit 2c7da04 into main

5 checks passed

Jiyeon-lunit deleted the DS-155-Docs-Color branch

March 25, 2024 10:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet