Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DS-107] fix TextField bug #140

Merged
merged 2 commits into from
Nov 15, 2023
Merged

[DS-107] fix TextField bug #140

merged 2 commits into from
Nov 15, 2023

Conversation

Jiyeon-lunit
Copy link
Contributor

@Jiyeon-lunit Jiyeon-lunit commented Nov 14, 2023 •
edited by jira bot
Loading

Description

  • Issue : DS-107
  • TextField 의 hover component 에 radius 적용이 되지 않아 해당 css 수정
  • MultiTextField 에서 onChange 이벤트가 입력되지 않는 이슈 수정

@Jiyeon-lunit Jiyeon-lunit self-assigned this Nov 14, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

Design System Storybook: https://ds-107-textfield-hover-radius--62d7d1f2efc8a1e364b5e5e8.chromatic.com

LTakhyunKim
LTakhyunKim approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@LTakhyunKim LTakhyunKim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

크게 놓친 부분이 있었는데 모르고 있었네요 ㅠㅠ... 수정 감사합니다! 🥹

@Jiyeon-lunit Jiyeon-lunit changed the title fix(textField): add border-radius at hover component [DS-107] fix TextField bug Nov 14, 2023
@Jiyeon-lunit Jiyeon-lunit merged commit bcbe239 into main Nov 15, 2023
4 of 5 checks passed
@Jiyeon-lunit Jiyeon-lunit deleted the DS-107-TextField-hover-radius branch November 15, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LTakhyunKim LTakhyunKim LTakhyunKim approved these changes

@deminoth deminoth Awaiting requested review from deminoth

Assignees

@Jiyeon-lunit Jiyeon-lunit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jiyeon-lunit @LTakhyunKim