Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DS-95] add TextField Error Focus status #139

Merged
merged 3 commits into from
Oct 31, 2023
Merged

[DS-95] add TextField Error Focus status #139

merged 3 commits into from
Oct 31, 2023

Conversation

LTakhyunKim
Copy link
Contributor

@LTakhyunKim LTakhyunKim commented Oct 31, 2023 •
edited
Loading

DS-95

Description

TextField 에 Error Focus 상태를 추가합니다.
스타일 수정 및 관련하여 story 를 추가했습니다.

스크린샷 2023-10-31 오후 3 30 05

@LTakhyunKim LTakhyunKim added the enhancement New feature or request label Oct 31, 2023
@LTakhyunKim LTakhyunKim self-assigned this Oct 31, 2023
@github-actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

Design System Storybook: https://ds-95-textfield-error-focus--62d7d1f2efc8a1e364b5e5e8.chromatic.com

@LTakhyunKim LTakhyunKim merged commit dfda729 into main Oct 31, 2023
3 checks passed
@LTakhyunKim LTakhyunKim deleted the ds-95-textfield-error-focus branch October 31, 2023 07:59
@deminoth
Copy link
Member

이거 approve 할 때 크로매틱 변경사항도 accept 했어야 하는데 깜빡했네요 지금 합니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deminoth deminoth deminoth approved these changes

@Jiyeon-lunit Jiyeon-lunit Awaiting requested review from Jiyeon-lunit

Assignees

@LTakhyunKim LTakhyunKim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LTakhyunKim @deminoth