[DS-87] TextField InputProps 미적용 이슈 해결 #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Design System Storybook: https://ds-87-textfield-inputprops--62d7d1f2efc8a1e364b5e5e8.chromatic.com |
deminoth
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DS-87
Description
Single TextField 사용 시, InputProps 가 적용되지 않는 이슈를 해결합니다.
이를 통해 Jira 티켓의 auto complete 레이아웃이 사라지는 이슈도 해결합니다.
해결되는 이유는 다음과 같습니다.
auto complete 레이아웃을 표기하기 위해선 Autocomplete renderInput props 의 parameter 를
TextField component 로 전달해야합니다. 위 parameter 에서
TextField InputProps Ref를 전달해야하는데,디자인 시스템 TextField 에서 InputProps 를 SingleTextField 로 전달하지 않아 레이아웃을 표기할 수 없는 이슈가 발생합니다.