refactor(button): apply component prop to BaseButtonProps interface

lunit-io · Oct 10, 2023 · 7bd03b6 · 7bd03b6
1 parent c323502
commit 7bd03b6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/design-system/src/components/Button/Button.tsx b/packages/design-system/src/components/Button/Button.tsx
@@ -4,9 +4,7 @@ import { CustomButton } from "./Button.styled";
 
 import type { ButtonProps } from "./Button.types";
 
-const Button = <C extends React.ElementType>(
-  props: ButtonProps & { component?: C }
-) => {
+const Button = (props: ButtonProps) => {
   const {
     size = "small",
     color = "primary",

diff --git a/packages/design-system/src/components/Button/Button.types.ts b/packages/design-system/src/components/Button/Button.types.ts
@@ -1,7 +1,9 @@
 import type { ButtonProps as MuiButtonProps } from "@mui/material";
 
-interface BaseButtonProps extends Omit<MuiButtonProps, "variant"> {
+interface BaseButtonProps
+  extends Omit<MuiButtonProps<React.ElementType>, "variant"> {
   icon?: React.ReactNode;
+  component?: React.ElementType;
 }
 
 interface ContainedButtonProps extends BaseButtonProps {