feat: change NonModal type as nonModal instead of undefined

lunit-io · Apr 15, 2024 · 09d3dea · 09d3dea
1 parent 6eadc6d
commit 09d3dea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/design-system/src/components/Dialog/Dialog.tsx b/packages/design-system/src/components/Dialog/Dialog.tsx
@@ -9,7 +9,7 @@ import type { SxProps } from "@mui/material/styles";
 export interface DialogPropsBase {
   isOpen: boolean;
   isSmall?: boolean;
-  modalType?: "passive" | "action";
+  modalType: "passive" | "action" | "nonModal";
   onClose(): void;
   children: React.ReactNode;
   sx?: SxProps;
@@ -31,7 +31,7 @@ export interface ActionModalProps extends DialogPropsBase {
 export type ModalProps = PassiveModalProps | ActionModalProps;
 
 export interface NonModalProps extends DialogPropsBase {
-  modalType?: undefined;
+  modalType: "nonModal";
   actions: React.ReactNode;
 }
 
@@ -40,7 +40,7 @@ export type DialogProps = ModalProps | NonModalProps;
 function Dialog(props: DialogProps) {
   const { isOpen, modalType, onClose } = props;
 
-  const nonModal = !modalType;
+  const nonModal = modalType === "nonModal";
   const isActionModal = modalType === "action";
   const isPassiveModal = modalType === "passive";
 

diff --git a/packages/design-system/src/stories/components/Dialog/Dialog.stories.tsx b/packages/design-system/src/stories/components/Dialog/Dialog.stories.tsx
@@ -131,6 +131,7 @@ export const NonModal: Story = {
 
         <Dialog
           className={classNameFromGlobal}
+          modalType="nonModal"
           isOpen={isOpen}
           isSmall
           onClose={close}