Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed receive modal not showing #691

Merged
merged 2 commits into from
May 14, 2018
Merged

fixed receive modal not showing #691

merged 2 commits into from
May 14, 2018

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented May 14, 2018

Thank you a lot for contributing to Cosmos Voyager!

Issue

closes: #690

❤️ Thank you!

@faboweb faboweb requested review from NodeGuy and nylira as code owners May 14, 2018 10:12
@codecov
Copy link

codecov bot commented May 14, 2018

Codecov Report

Merging #691 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop     #691   +/-   ##
========================================
  Coverage    86.62%   86.62%           
========================================
  Files           94       94           
  Lines         1540     1540           
  Branches        68       68           
========================================
  Hits          1334     1334           
  Misses         193      193           
  Partials        13       13
Impacted Files Coverage Δ
.../src/renderer/components/common/NiModalReceive.vue 100% <100%> (ø) ⬆️

@nylira
Copy link
Contributor

nylira commented May 14, 2018

I think your linter altered the Stylus when it shouldn’t have. I prefer the no commas no brackets style, but we can discuss that later.

@faboweb
Copy link
Collaborator Author

faboweb commented May 14, 2018

fixed

@nylira nylira merged commit bf445bb into develop May 14, 2018
@nylira nylira deleted the fabo/690-fix-receive-btn branch May 14, 2018 10:58
faboweb pushed a commit that referenced this pull request Jun 2, 2020
* disable emoney testnet

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The receive button doesn't open the receive modal
2 participants