Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peng/515 add tooltips #627

Merged
merged 6 commits into from
Apr 10, 2018
Merged

peng/515 add tooltips #627

merged 6 commits into from
Apr 10, 2018

Conversation

nylira
Copy link
Contributor

@nylira nylira commented Apr 10, 2018

  • use a customizable vue library for tooltips
  • update all current tooltips to use library
  • add tooltips for the block height and node ip
  • add tooltips for column titles on PageStaking.vue

Issue

Closes #515

Screenshots

screen shot 2018-04-10 at 2 57 25 pm

screen shot 2018-04-10 at 2 57 12 pm

screen shot 2018-04-10 at 2 57 00 pm

@nylira nylira requested review from faboweb and NodeGuy as code owners April 10, 2018 13:00
@codecov
Copy link

codecov bot commented Apr 10, 2018

Codecov Report

Merging #627 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           develop    #627   +/-   ##
=======================================
  Coverage     85.6%   85.6%           
=======================================
  Files           89      89           
  Lines         1507    1507           
  Branches        69      69           
=======================================
  Hits          1290    1290           
  Misses         203     203           
  Partials        14      14
Impacted Files Coverage Δ
app/src/renderer/main.js 89.28% <ø> (ø) ⬆️
app/src/renderer/components/monitor/PageBlock.vue 100% <100%> (ø) ⬆️
...enderer/components/govern/PageProposalsNewText.vue 42.85% <100%> (ø) ⬆️
...derer/components/govern/PageProposalsNewAdjust.vue 42.85% <100%> (ø) ⬆️
...rc/renderer/components/govern/PageProposalsNew.vue 100% <100%> (ø) ⬆️
...derer/components/govern/PageProposalsNewCreate.vue 42.85% <100%> (ø) ⬆️
app/src/renderer/components/monitor/PageBlocks.vue 100% <100%> (ø) ⬆️
...nderer/components/govern/PageProposalsNewAmend.vue 42.85% <100%> (ø) ⬆️
.../src/renderer/components/common/NiConnectivity.vue 100% <100%> (ø) ⬆️
...rc/renderer/components/wallet/PageTransactions.vue 100% <100%> (ø) ⬆️
... and 19 more

@@ -3,7 +3,7 @@
v-for="property in sort.properties",
@click="orderBy(property.value, $event)",
:class="property.class")
.label {{ property.title }}
.label(v-tooltip.top="property.tooltip") {{ property.title }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@faboweb faboweb merged commit 7564e31 into develop Apr 10, 2018
@faboweb faboweb deleted the peng/515-add-tooltips branch April 10, 2018 14:04
@jbibla
Copy link
Collaborator

jbibla commented Apr 10, 2018

🎉

faboweb pushed a commit that referenced this pull request Jun 2, 2020
* first commit. waiting on synced node

* use forbole endpoint. validators working

* add gas estimates for kava

* changelog

* change forbole picture link to do one

* enable most of the kava features and some actions

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants