Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename instances of cosmos ui to voyager #473

Merged
merged 9 commits into from
Feb 13, 2018
Merged

Conversation

nylira
Copy link
Contributor

@nylira nylira commented Feb 13, 2018

Your checklist for this pull request

  • Make sure you are requesting to pull your feature/bugfix branch (right side).
  • Make sure you are making a pull request against the develop branch (left side). Also make sure to start your branch off our develop.
  • If this PR produces a visible change, please provide screenshots showing these changes.
  • Confirm that your pull request will pass our linting and unit tests.
  • Make sure your code is properly tested, so that the code coverage is not decreasing.

Screenshot

screen shot 2018-02-13 at 1 38 51 pm

Issue

Closes #472

@nylira nylira requested a review from mappum as a code owner February 13, 2018 05:42
@nylira
Copy link
Contributor Author

nylira commented Feb 13, 2018

After this PR is merged, I would like to rename this repository to https://github.com/cosmos/voyager. GitHub will automatically redirect all requests to cosmos/cosmos-ui to cosmos/voyager. Info: https://github.com/blog/1508-repository-redirects-are-here

@nylira
Copy link
Contributor Author

nylira commented Feb 13, 2018

Also once we do this renaming, please everyone run this command in your local cosmos-ui project folder:

git remote set-url origin [email protected]:cosmos/voyager.git

It'll update the remote origin for pushing and pulling purposes so there will be less confusion later.

@codecov
Copy link

codecov bot commented Feb 13, 2018

Codecov Report

Merging #473 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop     #473   +/-   ##
========================================
  Coverage    79.06%   79.06%           
========================================
  Files           82       82           
  Lines         1309     1309           
  Branches        66       66           
========================================
  Hits          1035     1035           
  Misses         256      256           
  Partials        18       18
Impacted Files Coverage Δ
app/src/main/index.js 73.75% <ø> (ø) ⬆️
app/src/renderer/components/common/NiDataError.vue 100% <ø> (ø) ⬆️
app/src/main/menu.js 25% <ø> (ø) ⬆️
...rc/renderer/components/common/NiSessionWelcome.vue 100% <100%> (ø) ⬆️
app/src/renderer/components/common/NiModalHelp.vue 100% <100%> (ø) ⬆️

faboweb
faboweb previously approved these changes Feb 13, 2018
Copy link
Collaborator

@faboweb faboweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for after todays meeting to merge

@nylira
Copy link
Contributor Author

nylira commented Feb 13, 2018

Can we merge https://github.com/cosmos/cosmos.github.io/pull/101 after this one?

@nylira nylira merged commit 93cdf62 into develop Feb 13, 2018
@nylira nylira deleted the peng/472-rename-voyager branch February 13, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: rename cosmos-ui to voyager
3 participants