Jordan/388 profile #449
Jordan/388 profile #449
Conversation
…idator and candidate profiles,
Codecov Report
@@ Coverage Diff @@
## develop #449 +/- ##
=========================================
+ Coverage 75.79% 76.2% +0.4%
=========================================
Files 91 90 -1
Lines 1409 1387 -22
Branches 69 66 -3
=========================================
- Hits 1068 1057 -11
+ Misses 321 312 -9
+ Partials 20 18 -2
|
|
Ah this may have been better made on top of my #427 PR. A lot of the changes are duplicated. |
| computed: { | ||
| ...mapGetters(['user']), | ||
| userInfo () { | ||
| console.log(this.user) |
There was a problem hiding this comment.
was it intended to leave this in? userInfo will be null I guess and is not used in the component
| div(slot="menu"): tool-bar | ||
| router-link(to="/validators" exact) | ||
| i.material-icons arrow_back | ||
| .label Back | ||
|
|
There was a problem hiding this comment.
so this will be a completely empty page? is this one of the components we don't use anymore?
There was a problem hiding this comment.
i will delete this file.
| let wrapper, store, router | ||
| let {mount} = setup() | ||
| let wrapper | ||
| let store = new Vuex.Store({ |
There was a problem hiding this comment.
why did you choose to remove the helper?
There was a problem hiding this comment.
assuming i understand correctly... because the helper installs localVue.use(VueRouter). $route becomes read only and cannot be set manually (overridden) in the test.
https://vue-test-utils.vuejs.org/en/guides/using-with-vue-router.html
There was a problem hiding this comment.
but before it worked with router.push('/staking/delegates/pubkeyX') or not?
There was a problem hiding this comment.
There was a problem hiding this comment.
i think it worked before with router.push because there were no params involved.
There was a problem hiding this comment.
The route is defined as /staking/delegates/:delegate :delegate is the param you want to get in the component. When you push the route /staking/delegates/pubkeyX it will set the param delegate to pubkeyX. This is how it worked before.
As already mentioned, I would like to change the test setup back to using vuex-setup for consistency and to also test vuex-actions existence (lite e2e testing).
There was a problem hiding this comment.
OH! ok! let me try that out. that would be better!
|
simple profile page where the word "Validator" will change to "Candidate" if the delegate is not a validator. removed all data that is not available. generic for all delegates.
|
this is a PR that simplifies the user profile page and the delegate profile page. both candidates and validators can now use
PageDelegateas their profile pages. i also removed a lot of unused code.closes #388