Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peng/406 fix page bond #414

Merged
merged 8 commits into from
Jan 30, 2018
Merged

Peng/406 fix page bond #414

merged 8 commits into from
Jan 30, 2018

Conversation

nylira
Copy link
Contributor

@nylira nylira commented Jan 30, 2018

  • Improves performance of amountBonded in LiDelegate.vue
  • Prevents user from going to PageBond if they don't have any atoms/fermions
  • Hides the bonding interface on PageDelegates if the user doesn't have any atoms

Closes #406

@nylira nylira requested a review from mappum as a code owner January 30, 2018 03:51
faboweb
faboweb approved these changes Jan 30, 2018
View reviewed changes
CHANGELOG.md

## [0.3.1] - 2018-01-30
### Changed
* Improved performance of amountBonded in LiDelegate.vue @nylira.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for using the changelog. have to put this in my routine still

@faboweb faboweb merged commit 3a3e080 into develop Jan 30, 2018
@faboweb faboweb deleted the peng/406-fix-page-bond branch January 30, 2018 10:44
@faboweb
Copy link
Collaborator

faboweb commented Jan 30, 2018

Good PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faboweb faboweb faboweb approved these changes

@mappum mappum Awaiting requested review from mappum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nylira @faboweb