Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Simsala] automatic release created for v1.0.155 #3335

Merged
merged 8 commits into from
Dec 18, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Dec 18, 2019

Please manually test before merging this to master

Changed

  • #3313 Now when Linux users go to sign in with Ledger they get a warning message with a link to the Ledger documentation to fix connection issues @Bitcoinera
  • #3289 Now PageValidator handles empty fields more uniformly, always displaying -- @Bitcoinera

Fixed

  • #3323 Fixes the userTransactionAdded subscription and deletes the double TmLoadingComponent @Bitcoinera
  • Show failing txs in action modal @faboweb
  • #3277 Update proposals every 10 blocks @mariopino

faboweb and others added 8 commits December 16, 2019 17:39
* handle picture is null

* changelog

* handle null images on page validator
* Update proposals every 10 blocks

* changelog

* istanbul ignore next

* Trigger CI

* istanbul ignore next

* Use loaded

* Update snap

* istanbul ignore next

* Update single proposal page every new block

* Job is done!

* Comment

* Remove comment

* istanbul ignore next

* Improve coverage

* Update all proposal data

* Simplify

* Revert

* Fix watcher func testing

* Fix, cleanup, optimization

* Update snap

* Cleanup
* chooseFilter for pagevalidator. fix website

* changelog

* add filter as second parameter

* add test for isblankfield

* lint
…#3315)

* add linux webusb message. center signin button

* add linux test but it errors. lint

* changelog

* fix linux message test
* small but important fixes

* changelog
* add new property to receive notification if tx inclusion failed

* dev life

* changelog

* fix tests
@faboweb faboweb requested review from colw and jbibla as code owners December 18, 2019 19:19
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #3335 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3335      +/-   ##
==========================================
+ Coverage   90.59%   90.72%   +0.12%     
==========================================
  Files         126      126              
  Lines        1968     1973       +5     
  Branches      301      292       -9     
==========================================
+ Hits         1783     1790       +7     
+ Misses        180      178       -2     
  Partials        5        5
Impacted Files Coverage Δ
src/ActionModal/utils/ActionManager.js 100% <ø> (ø) ⬆️
src/components/common/TmSessionHardware.vue 100% <100%> (ø) ⬆️
src/ActionModal/components/SendModal.vue 93.33% <100%> (+0.31%) ⬆️
src/components/staking/PageValidator.vue 40% <100%> (+1.36%) ⬆️
src/components/governance/PageProposals.vue 100% <100%> (+7.14%) ⬆️
src/components/governance/PageProposal.vue 100% <100%> (+2.94%) ⬆️

@faboweb faboweb merged commit d764901 into master Dec 18, 2019
@faboweb faboweb deleted the release-candidate/v1.0.155 branch December 18, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants